netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Fastabend <john.fastabend@gmail.com>
To: Jamal Hadi Salim <jhs@mojatatu.com>
Cc: john Fastabend <john.r.fastabend@intel.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	Cong Wang <xiyou.wangcong@gmail.com>
Subject: Re: action stats broken?
Date: Sat, 20 Sep 2014 08:21:28 -0700	[thread overview]
Message-ID: <541D9B78.8070505@gmail.com> (raw)
In-Reply-To: <541D7E55.6070306@mojatatu.com>

On 09/20/2014 06:17 AM, Jamal Hadi Salim wrote:
>
> Sorry, dont have time to chase this today and it may be fixed in the
> latest  tree. Possibly recent patches or likely earlier patches
> even.
>
> It seems stats are no longer displaying for actions.
> This is a net-next kernel. I have tried kernel 3.16.0-rc2
> and 3.17.0-rc4 with same results.
>
> Simple test case:
>
> ----
> root@moja-1:~# tc actions add  action drop index 4
> root@moja-1:~# tc -s actions ls action gact
>
>      action order 0: gact action drop
>       random type none pass val 0
>       index 4 ref 1 bind 0 installed 9 sec used 4 sec
> -----
>
> What I would have expected to see is:
> ---
>      action order 0: gact action drop
>       random type none pass val 0
>       index 4 ref 1 bind 0 installed 9 sec used 4 sec
>           Sent 108948 bytes 1297 pkts (dropped 1297, overlimits 0)
> ---
>
>

I'm looking into it which classifier? A basic u32 classifier attached
to the ingress qdisc seems to work. If your using u32 any hash tables,
or 'filter change' commands before this?

# tc actions add  action drop index 4

# tc filter add dev p3p1 parent ffff:0 protocol ip prio 100 \
	u32 match ip src 16.0.0.2 action gact index 4

#tc -s actions ls action gact

         action order 0: gact action drop
          random type none pass val 0
          index 4 ref 2 bind 1 installed 142 sec used 0 sec
         Action statistics:
         Sent 840 bytes 10 pkt (dropped 10, overlimits 0 requeues 0)
         backlog 0b 0p requeues 0


> cheers,
> jamal
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


-- 
John Fastabend         Intel Corporation

  reply	other threads:[~2014-09-20 15:21 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-20 13:17 action stats broken? Jamal Hadi Salim
2014-09-20 15:21 ` John Fastabend [this message]
2014-09-21 12:33   ` Jamal Hadi Salim
2014-09-21 14:21     ` Jamal Hadi Salim
2014-09-21 14:50       ` John Fastabend
2014-09-21 15:01         ` Jamal Hadi Salim

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=541D9B78.8070505@gmail.com \
    --to=john.fastabend@gmail.com \
    --cc=jhs@mojatatu.com \
    --cc=john.r.fastabend@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=xiyou.wangcong@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).