From mboxrd@z Thu Jan 1 00:00:00 1970 From: Arend van Spriel Subject: Re: [PATCH] brcmfmac: Fix off by one bug in brcmf_count_20mhz_channels() Date: Mon, 22 Sep 2014 11:49:56 +0200 Message-ID: <541FF0C4.9020805@broadcom.com> References: <1411253932-27973-1-git-send-email-emilgoode@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1"; format=flowed Content-Transfer-Encoding: 7bit Cc: Brett Rudley , "Franky (Zhenhui) Lin" , Hante Meuleman , "John W. Linville" , Pieter-Paul Giesberts , Daniel Kim , , , , , To: Emil Goode Return-path: In-Reply-To: <1411253932-27973-1-git-send-email-emilgoode@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 09/21/14 00:58, Emil Goode wrote: > In the brcmf_count_20mhz_channels function we are looping through a list > of channels received from firmware. Since the index of the first channel > is 0 the condition leads to an off by one bug. This is causing us to hit > the WARN_ON_ONCE(1) calls in the brcmu_d11n_decchspec function, which is > how I discovered the bug. > > Introduced by: > commit b48d891676f756d48b4d0ee131e4a7a5d43ca417 > ("brcmfmac: rework wiphy structure setup") My bad :-(. You can add: Acked-by: Arend van Spriel > Signed-off-by: Emil Goode > --- > drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c > index 02fe706..93b5dd9 100644 > --- a/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c > +++ b/drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c > @@ -4918,7 +4918,7 @@ static void brcmf_count_20mhz_channels(struct brcmf_cfg80211_info *cfg, > struct brcmu_chan ch; > int i; > > - for (i = 0; i<= total; i++) { > + for (i = 0; i< total; i++) { > ch.chspec = (u16)le32_to_cpu(chlist->element[i]); > cfg->d11inf.decchspec(&ch); >