Re: [PATCH] net/sched: initialize noop_qdisc owner

[Eric Dumazet <eric.dumazet@gmail.com>]

On 6/7/24 17:53, Johannes Berg wrote:
> From: Johannes Berg <johannes.berg@intel.com>
>
> When the noop_qdisc owner isn't initialized, then it will be 0,
> so packets will erroneously be regarded as having been subject
> to recursion as long as only CPU 0 queues them. For non-SMP,
> that's all packets, of course. This causes a change in what's
> reported to userspace, normally noop_qdisc would drop packets
> silently, but with this change the syscall returns -ENOBUFS if
> RECVERR is also set on the socket.
>
> Fix this by initializing the owner field to -1, just like it
> would be for dynamically allocated qdiscs by qdisc_alloc().
>
> Fixes: 0f022d32c3ec ("net/sched: Fix mirred deadlock on device recursion")
> Signed-off-by: Johannes Berg <johannes.berg@intel.com>


I found this quite by luck.

Please CC maintainers next time, and blamed patch authors :/

Believe it or not, I do not follow netdev@ traffic.

Reviewed-by: Eric Dumazet <edumazet@google.com>

Thanks.