From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next v12 3/7] sch_cake: Add optional ACK filter
Date: Thu, 17 May 2018 04:56:26 -0700
Message-ID: <541d62af-3938-5fdc-666c-dd243fa465b5@gmail.com>
References: <152650253056.25701.10138252969621361651.stgit@alrua-kau>
 <152650254614.25701.1377066681230937234.stgit@alrua-kau>
 <a002ff7b-2606-afcd-1769-b216f4db428c@gmail.com> <87in7my196.fsf@toke.dk>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
Cc: cake@lists.bufferbloat.net
To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= <toke@toke.dk>,
        Eric Dumazet <eric.dumazet@gmail.com>, netdev@vger.kernel.org
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f67.google.com ([209.85.160.67]:45367 "EHLO
        mail-pl0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751061AbeEQL42 (ORCPT
        <rfc822;netdev@vger.kernel.org>); Thu, 17 May 2018 07:56:28 -0400
Received: by mail-pl0-f67.google.com with SMTP id bi12-v6so2399928plb.12
        for <netdev@vger.kernel.org>; Thu, 17 May 2018 04:56:28 -0700 (PDT)
In-Reply-To: <87in7my196.fsf@toke.dk>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 05/17/2018 04:23 AM, Toke Høiland-Jørgensen wrote:

> 
> We don't do full parsing of SACKs, no; we were trying to keep things
> simple... We do detect the presence of SACK options, though, and the
> presence of SACK options on an ACK will make previous ACKs be considered
> redundant.
> 

But they are not redundant in some cases, particularly when reorders happen in the network.