netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Daniel Borkmann <dborkman@redhat.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Florian Westphal <fw@strlen.de>,
	davem@davemloft.net, hagen@jauu.net, lars@netapp.com,
	eric.dumazet@gmail.com, fontana@sharpeleven.org,
	hannes@stressinduktion.org, glenn.judd@morganstanley.com,
	netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2 2/5] net: tcp: add flag for ca to indicate that ECN is required
Date: Tue, 23 Sep 2014 11:17:17 +0200	[thread overview]
Message-ID: <54213A9D.6060400@redhat.com> (raw)
In-Reply-To: <20140922092606.10977e48@urahara>

Hi Stephen,

On 09/22/2014 06:26 PM, Stephen Hemminger wrote:
> On Sat, 20 Sep 2014 23:29:19 +0200
> Florian Westphal <fw@strlen.de> wrote:
>
>> +static inline void
>> +TCP_ECN_create_request(struct request_sock *req, const struct sk_buff *skb,
>> +		       const struct sock *listen_sk)
>
> Maybe good time to switch to lower case here for function name.

thanks for your feedback and review, much appreciated! I think
it makes sense and we would send a follow-up clean-up patch that
replaces TCP_ECN_* with tcp_ecn_* in this and other function names.

Thanks,

Daniel, Florian

  parent reply	other threads:[~2014-09-23  9:17 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-09-20 21:29 [PATCH net-next v2 0/5] net: tcp: DCTCP congestion control algorithm Florian Westphal
2014-09-20 21:29 ` [PATCH net-next v2 1/5] net: tcp: assign tcp cong_ops when tcp sk is created Florian Westphal
2014-09-20 21:29 ` [PATCH net-next v2 2/5] net: tcp: add flag for ca to indicate that ECN is required Florian Westphal
2014-09-22 16:26   ` Stephen Hemminger
2014-09-22 20:11     ` Hagen Paul Pfeifer
2014-09-23  9:17     ` Daniel Borkmann [this message]
2014-09-22 20:33   ` David Miller
2014-09-23  9:11     ` Florian Westphal
2014-09-26 20:20       ` David Miller
2014-09-26 20:39         ` Daniel Borkmann
2014-09-20 21:29 ` [PATCH net-next v2 3/5] net: tcp: split ack slow/fast events from cwnd_event Florian Westphal
2014-09-20 21:29 ` [PATCH net-next v2 4/5] net: tcp: more detailed ACK events and events for CE marked packets Florian Westphal
2014-09-20 21:29 ` [PATCH net-next v2 5/5] net: tcp: add DCTCP congestion control algorithm Florian Westphal
2014-09-22 16:28 ` [PATCH net-next v2 0/5] net: tcp: " Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54213A9D.6060400@redhat.com \
    --to=dborkman@redhat.com \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=fontana@sharpeleven.org \
    --cc=fw@strlen.de \
    --cc=glenn.judd@morganstanley.com \
    --cc=hagen@jauu.net \
    --cc=hannes@stressinduktion.org \
    --cc=lars@netapp.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).