From: John Fastabend <john.r.fastabend@intel.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net, John Fastabend <john.fastabend@gmail.com>
Subject: Re: [Patch net-next 2/2] net_sched: fix another regression in cls_tcindex
Date: Thu, 25 Sep 2014 14:18:15 -0700 [thread overview]
Message-ID: <54248697.2010202@intel.com> (raw)
In-Reply-To: <1411671965-18887-2-git-send-email-xiyou.wangcong@gmail.com>
On 09/25/2014 12:06 PM, Cong Wang wrote:
> Clearly the following change is not expected:
>
> - if (!cp.perfect && !cp.h)
> - cp.alloc_hash = cp.hash;
> + if (!cp->perfect && cp->h)
> + cp->alloc_hash = cp->hash;
>
> Fixes: commit 331b72922c5f58d48fd ("net: sched: RCU cls_tcindex")
> Cc: John Fastabend <john.fastabend@gmail.com>
> Signed-off-by: Cong Wang <xiyou.wangcong@gmail.com>
> ---
> net/sched/cls_tcindex.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/net/sched/cls_tcindex.c b/net/sched/cls_tcindex.c
> index 9d78fd7..a18eb1b 100644
> --- a/net/sched/cls_tcindex.c
> +++ b/net/sched/cls_tcindex.c
> @@ -303,7 +303,7 @@ tcindex_set_parms(struct net *net, struct tcf_proto *tp, unsigned long base,
> cp->hash = DEFAULT_HASH_SIZE;
> }
>
> - if (!cp->perfect && cp->h)
> + if (!cp->perfect && !cp->h)
> cp->alloc_hash = cp->hash;
>
> /* Note: this could be as restrictive as if (handle & ~(mask >> shift))
>
Dang thanks. I added a test to my scripts that doesn't set the
hash explicitly with TCA_TCINDEX_HASH. It looks like changes to
the filter after the initial setup could fail without this fix.
Acked-by: John Fastabend <john.r.fastabend@intel.com>
next prev parent reply other threads:[~2014-09-25 21:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-25 19:06 [Patch net-next 1/2] net_sched: fix errno in tcindex_set_parms() Cong Wang
2014-09-25 19:06 ` [Patch net-next 2/2] net_sched: fix another regression in cls_tcindex Cong Wang
2014-09-25 21:18 ` John Fastabend [this message]
2014-09-28 21:35 ` David Miller
2014-09-25 21:07 ` [Patch net-next 1/2] net_sched: fix errno in tcindex_set_parms() John Fastabend
2014-09-25 22:57 ` John Fastabend
2014-09-26 0:27 ` John Fastabend
2014-09-28 21:35 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54248697.2010202@intel.com \
--to=john.r.fastabend@intel.com \
--cc=davem@davemloft.net \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).