From: Daniel Borkmann <dborkman@redhat.com>
To: David L Stevens <david.stevens@oracle.com>
Cc: davem@davemloft.net, hannes@stressinduktion.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/3] ipv6: mld: do not overwrite uri when receiving an mldv2 query
Date: Fri, 26 Sep 2014 14:23:48 +0200 [thread overview]
Message-ID: <54255AD4.409@redhat.com> (raw)
In-Reply-To: <54255875.20409@oracle.com>
On 09/26/2014 02:13 PM, David L Stevens wrote:
> On 09/26/2014 05:29 AM, Daniel Borkmann wrote:
>> On 09/26/2014 01:23 AM, David L Stevens wrote:
>
>> I'm fine with either suggestion. Actually the _current_ situation we're in is
>> that in IPv4 we _always_ use the current, uncached _sysctl_ tuned setting of URI
>> (independent of any protocol version); while in IPv6 we use the _cached_ sysctl
>> URI in case of MLDv1 and _always_ overwrite the URI in case of MLDv2 (even for
>> MLDv1). Are you suggesting that, we then better adapt using the maxdelay value
>> everywhere and adapt URI to it, plus having a boolean knob defaulting to off for
>> an admin to enforce always using the provided sysctl default setting and not
>> the snooped MLD?
>
> Yes.
>
> Definitely, IGMP and MLD, all versions, should do the same thing and I think that
> ought to use the querier MRC, if present and not overridden by an admin.
>
> Further, I think a version switch or failure to hear from a querier for qrv*qi
> ought to reset everything.
I'll recook the patch set and keep you in the loop. Thanks David!
Best,
Daniel
next prev parent reply other threads:[~2014-09-26 12:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 7:03 [PATCH net-next 0/3] mld updates, part 2 Daniel Borkmann
2014-09-23 7:03 ` [PATCH net-next 1/3] ipv6: mld: rename mc_maxdelay into mc_uri Daniel Borkmann
2014-09-24 20:34 ` Hannes Frederic Sowa
2014-09-23 7:03 ` [PATCH net-next 2/3] ipv6: mld: do not overwrite uri when receiving an mldv2 query Daniel Borkmann
2014-09-24 20:36 ` Hannes Frederic Sowa
2014-09-25 16:02 ` David L Stevens
2014-09-25 20:06 ` Daniel Borkmann
2014-09-25 23:23 ` David L Stevens
2014-09-26 9:29 ` Daniel Borkmann
2014-09-26 12:13 ` David L Stevens
2014-09-26 12:23 ` Daniel Borkmann [this message]
2014-09-25 23:29 ` David L Stevens
2014-09-23 7:03 ` [PATCH net-next 3/3] ipv6: mld: remove duplicate code from mld_update_qri Daniel Borkmann
2014-09-24 20:36 ` Hannes Frederic Sowa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54255AD4.409@redhat.com \
--to=dborkman@redhat.com \
--cc=davem@davemloft.net \
--cc=david.stevens@oracle.com \
--cc=hannes@stressinduktion.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).