From: Rick Jones <rick.jones2@hp.com>
To: David L Stevens <david.stevens@oracle.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net
Subject: Re: [PATCH net-next] udp: increment UDP_NO_PORTS when dropping unmatched multicasts
Date: Wed, 01 Oct 2014 09:32:43 -0700 [thread overview]
Message-ID: <542C2CAB.2030501@hp.com> (raw)
In-Reply-To: <542C23AA.6060505@oracle.com>
On 10/01/2014 08:54 AM, David L Stevens wrote:
> I think this would have the unpleasant side-effect of incrementing a drop
> stat when we have not joined a multicast group that has UDP traffic, but the
> interface is in promiscuous mode. Also, false positives for the multicast
> address filter.
>
> Multicast address filters are not perfect matches, so it is "normal" to receive
> multicasts and broadcasts that are not addressed to our host. I'm not sure those
> should count as "noports" any more than traffic addressed to someone else's IP
> address if we're in promiscuous mode should.
>
> In the multicast case, it would really only make sense if we have actually joined
> the group it's addressed to.
Do you think an "ignored" statistic would be appropriate then?
rick
next prev parent reply other threads:[~2014-10-01 16:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 15:19 [PATCH net-next] udp: increment UDP_NO_PORTS when dropping unmatched multicasts Rick Jones
2014-10-01 15:41 ` Eric Dumazet
2014-10-01 15:54 ` David L Stevens
2014-10-01 16:32 ` Rick Jones [this message]
2014-10-01 16:59 ` David L Stevens
2014-10-01 17:32 ` Rick Jones
2014-10-01 17:43 ` David L Stevens
2014-10-01 17:51 ` Rick Jones
2014-10-01 17:14 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542C2CAB.2030501@hp.com \
--to=rick.jones2@hp.com \
--cc=davem@davemloft.net \
--cc=david.stevens@oracle.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).