From: David L Stevens <david.stevens@oracle.com>
To: Rick Jones <rick.jones2@hp.com>, netdev@vger.kernel.org
Cc: davem@davemloft.net
Subject: Re: [PATCH net-next] udp: increment UDP_NO_PORTS when dropping unmatched multicasts
Date: Wed, 01 Oct 2014 12:59:18 -0400 [thread overview]
Message-ID: <542C32E6.7080106@oracle.com> (raw)
In-Reply-To: <542C2CAB.2030501@hp.com>
On 10/01/2014 12:32 PM, Rick Jones wrote:
>
> Do you think an "ignored" statistic would be appropriate then?
I guess I don't know what that means. If we didn't join the group, it
should be treated like anything we'd receive in promiscuous mode that
is not addressed to us. I'd assume interface stats are going up, but not
any protocol stats in that case. (already the case)
If we did join the group, it should be treated the way we would, say,
a broadcast UDP packet where we have no listener on that port.
It isn't clear to me that maintaining the stat is worth checking for
group membership, but we wouldn't want an admin to conclude there is
a problem or an error because we increment a stat when doing the
equivalent of hardware MAC address filtering, just because multicast
address filters are defined to be leaky.
+-DLS
next prev parent reply other threads:[~2014-10-01 16:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-01 15:19 [PATCH net-next] udp: increment UDP_NO_PORTS when dropping unmatched multicasts Rick Jones
2014-10-01 15:41 ` Eric Dumazet
2014-10-01 15:54 ` David L Stevens
2014-10-01 16:32 ` Rick Jones
2014-10-01 16:59 ` David L Stevens [this message]
2014-10-01 17:32 ` Rick Jones
2014-10-01 17:43 ` David L Stevens
2014-10-01 17:51 ` Rick Jones
2014-10-01 17:14 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542C32E6.7080106@oracle.com \
--to=david.stevens@oracle.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=rick.jones2@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).