From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Claudiu Manoil <claudiu.manoil@freescale.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
Xiubo Li <Li.Xiubo@freescale.com>,
Shruti Kanetkar <Shruti@freescale.com>
Subject: Re: [net 1/8] net/fsl_pq_mdio: Fix asm/ucc.h compile error for ARM
Date: Fri, 03 Oct 2014 22:39:12 +0400 [thread overview]
Message-ID: <542EED50.9040309@cogentembedded.com> (raw)
In-Reply-To: <1412352169-14414-2-git-send-email-claudiu.manoil@freescale.com>
Hello.
On 10/03/2014 08:02 PM, Claudiu Manoil wrote:
> The UCC specific code included in fsl_pq_mdio.c (with
> function calls from asm/ucc.h) is already guarded
> by these config options, so this ARM build fix provides
> consistency with the rest UCC specific code.
> Signed-off-by: Claudiu Manoil <claudiu.manoil@freescale.com>
> ---
> drivers/net/ethernet/freescale/fsl_pq_mdio.c | 2 ++
> 1 file changed, 2 insertions(+)
> diff --git a/drivers/net/ethernet/freescale/fsl_pq_mdio.c b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
> index 583e71a..89b3fea 100644
> --- a/drivers/net/ethernet/freescale/fsl_pq_mdio.c
> +++ b/drivers/net/ethernet/freescale/fsl_pq_mdio.c
> @@ -28,7 +28,9 @@
> #include <linux/of_device.h>
>
> #include <asm/io.h>
> +#if defined(CONFIG_UCC_GETH) || defined(CONFIG_UCC_GETH_MODULE)
Use IS_ENABLED(CONFIG_UCC_GETH) instead.
WBR, Sergei
next prev parent reply other threads:[~2014-10-03 18:39 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 16:02 [net 0/8] gianfar: ARM port driver updates (1/2) Claudiu Manoil
2014-10-03 16:02 ` [net 1/8] net/fsl_pq_mdio: Fix asm/ucc.h compile error for ARM Claudiu Manoil
2014-10-03 18:39 ` Sergei Shtylyov [this message]
2014-10-03 16:02 ` [net 2/8] net/fsl_pq_mdio: Use ioread/iowrite32be() portable accessors Claudiu Manoil
2014-10-03 16:02 ` [net 3/8] net/fsl_pq_mdio: Replace spin_event_timeout() with arch independent Claudiu Manoil
2014-10-03 16:02 ` [net 4/8] gianfar: Include missing headers for ARM builds Claudiu Manoil
2014-10-03 16:02 ` [net 5/8] gianfar: Exclude PPC specific errata handling from " Claudiu Manoil
2014-10-03 16:02 ` [net 6/8] gianfar: Make MAC addr setup endian safe, cleanup Claudiu Manoil
2014-10-03 16:02 ` [net 7/8] gianfar: Replace spin_event_timeout() with arch independent Claudiu Manoil
2014-10-03 16:02 ` [net 8/8] gianfar: Replace eieio with wmb for non-PPC archs Claudiu Manoil
2014-10-03 21:20 ` [net 0/8] gianfar: ARM port driver updates (1/2) Kim Phillips
2014-10-06 1:27 ` David Miller
2014-10-06 7:55 ` Claudiu Manoil
2014-10-06 19:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542EED50.9040309@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=Li.Xiubo@freescale.com \
--cc=Shruti@freescale.com \
--cc=claudiu.manoil@freescale.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).