From: John Fastabend <john.r.fastabend@intel.com>
To: Cong Wang <cwang@twopensource.com>,
John Fastabend <john.fastabend@gmail.com>
Cc: Cong Wang <xiyou.wangcong@gmail.com>,
David Miller <davem@davemloft.net>,
netdev <netdev@vger.kernel.org>,
Jamal Hadi Salim <jhs@mojatatu.com>,
Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH v1 2/2] net: sched: replace ematch calls to use struct net
Date: Fri, 03 Oct 2014 17:19:19 -0700 [thread overview]
Message-ID: <542F3D07.6090008@intel.com> (raw)
In-Reply-To: <CAHA+R7PWrAk1+ds8SNytf0dABwcSQYqSAvK9dTN44kQqRiq4Rw@mail.gmail.com>
On 10/03/2014 03:40 PM, Cong Wang wrote:
> On Thu, Oct 2, 2014 at 10:46 PM, John Fastabend
> <john.fastabend@gmail.com> wrote:
>> diff --git a/net/sched/cls_basic.c b/net/sched/cls_basic.c
>> index 81ddfa6..f37e4fb 100644
>> --- a/net/sched/cls_basic.c
>> +++ b/net/sched/cls_basic.c
>> @@ -32,7 +32,7 @@ struct basic_filter {
>> struct tcf_exts exts;
>> struct tcf_ematch_tree ematches;
>> struct tcf_result res;
>> - struct tcf_proto *tp;
>> + struct net *net;
>> struct list_head link;
>> struct rcu_head rcu;
>> };
>
> I guess storing this net pointer to struct tcf_ematch_tree is better,
> since it is only used by ematch?
Sure, that is fine. It is used by em_ipset and three classifiers. It
does simplify the API slightly if its in tcf_ematch, I guess. So I'll
move it there.
> --
> To unsubscribe from this list: send the line "unsubscribe netdev" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
prev parent reply other threads:[~2014-10-04 0:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 5:45 [PATCH v1 1/2] net: sched: do not use tcf_proto 'tp' argument from call_rcu John Fastabend
2014-10-03 5:46 ` [PATCH v1 2/2] net: sched: replace ematch calls to use struct net John Fastabend
2014-10-03 22:40 ` Cong Wang
2014-10-04 0:19 ` John Fastabend [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=542F3D07.6090008@intel.com \
--to=john.r.fastabend@intel.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jhs@mojatatu.com \
--cc=john.fastabend@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).