* [PATCH] drivers/net/can/m_can/Kconfig: Let CAN_M_CAN depend on HAS_IOMEM
@ 2014-10-04 10:00 Chen Gang
2014-10-04 11:05 ` Varka Bhadram
0 siblings, 1 reply; 3+ messages in thread
From: Chen Gang @ 2014-10-04 10:00 UTC (permalink / raw)
To: wg, mkl, fengguang.wu, b29396, varkabhadram
Cc: linux-can, netdev, linux-kernel
CAN_M_CAN needs HAS_IOMEM, so depend on it, the related error (with
allmodconfig under um):
MODPOST 1205 modules
ERROR: "devm_ioremap" [drivers/net/can/m_can/m_can.ko] undefined!
ERROR: "devm_ioremap_resource" [drivers/net/can/m_can/m_can.ko] undefined!
Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
---
drivers/net/can/m_can/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/net/can/m_can/Kconfig b/drivers/net/can/m_can/Kconfig
index fca5482..14c9fcf 100644
--- a/drivers/net/can/m_can/Kconfig
+++ b/drivers/net/can/m_can/Kconfig
@@ -1,4 +1,5 @@
config CAN_M_CAN
tristate "Bosch M_CAN devices"
+ depends on HAS_IOMEM
---help---
Say Y here if you want to support for Bosch M_CAN controller.
--
1.9.3
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/can/m_can/Kconfig: Let CAN_M_CAN depend on HAS_IOMEM
2014-10-04 10:00 [PATCH] drivers/net/can/m_can/Kconfig: Let CAN_M_CAN depend on HAS_IOMEM Chen Gang
@ 2014-10-04 11:05 ` Varka Bhadram
2014-10-04 11:49 ` Chen Gang
0 siblings, 1 reply; 3+ messages in thread
From: Varka Bhadram @ 2014-10-04 11:05 UTC (permalink / raw)
To: Chen Gang, wg, mkl, fengguang.wu, b29396; +Cc: linux-can, netdev, linux-kernel
Hi Chen Gang
I think commit message should be short and proper.
We can remove *drivers/net/can/m_can/Kconfig* in the commit, just
give *can: Kconfig: *
commit message like : *can: Kconfig: Fix CAN_M_CAN dependency*
On Saturday 04 October 2014 03:30 PM, Chen Gang wrote:
> CAN_M_CAN needs HAS_IOMEM, so depend on it, the related error (with
> allmodconfig under um):
>
> MODPOST 1205 modules
> ERROR: "devm_ioremap" [drivers/net/can/m_can/m_can.ko] undefined!
> ERROR: "devm_ioremap_resource" [drivers/net/can/m_can/m_can.ko] undefined!
>
> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
> ---
> drivers/net/can/m_can/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/can/m_can/Kconfig b/drivers/net/can/m_can/Kconfig
> index fca5482..14c9fcf 100644
> --- a/drivers/net/can/m_can/Kconfig
> +++ b/drivers/net/can/m_can/Kconfig
> @@ -1,4 +1,5 @@
> config CAN_M_CAN
> tristate "Bosch M_CAN devices"
> + depends on HAS_IOMEM
> ---help---
> Say Y here if you want to support for Bosch M_CAN controller.
--
Thanks and Regards,
Varka Bhadram.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drivers/net/can/m_can/Kconfig: Let CAN_M_CAN depend on HAS_IOMEM
2014-10-04 11:05 ` Varka Bhadram
@ 2014-10-04 11:49 ` Chen Gang
0 siblings, 0 replies; 3+ messages in thread
From: Chen Gang @ 2014-10-04 11:49 UTC (permalink / raw)
To: Varka Bhadram, wg, mkl, fengguang.wu, b29396
Cc: linux-can, netdev, linux-kernel
On 10/4/14 19:05, Varka Bhadram wrote:
> Hi Chen Gang
>
>
> I think commit message should be short and proper.
>
> We can remove *drivers/net/can/m_can/Kconfig* in the commit, just
> give *can: Kconfig: *
>
> commit message like : *can: Kconfig: Fix CAN_M_CAN dependency*
>
OK, thanks, it sounds good to me. If necessary to send patch v2 for it,
please let me know.
Thanks.
> On Saturday 04 October 2014 03:30 PM, Chen Gang wrote:
>> CAN_M_CAN needs HAS_IOMEM, so depend on it, the related error (with
>> allmodconfig under um):
>>
>> MODPOST 1205 modules
>> ERROR: "devm_ioremap" [drivers/net/can/m_can/m_can.ko] undefined!
>> ERROR: "devm_ioremap_resource" [drivers/net/can/m_can/m_can.ko] undefined!
>>
>> Signed-off-by: Chen Gang <gang.chen.5i5j@gmail.com>
>> ---
>> drivers/net/can/m_can/Kconfig | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/drivers/net/can/m_can/Kconfig b/drivers/net/can/m_can/Kconfig
>> index fca5482..14c9fcf 100644
>> --- a/drivers/net/can/m_can/Kconfig
>> +++ b/drivers/net/can/m_can/Kconfig
>> @@ -1,4 +1,5 @@
>> config CAN_M_CAN
>> tristate "Bosch M_CAN devices"
>> + depends on HAS_IOMEM
>> ---help---
>> Say Y here if you want to support for Bosch M_CAN controller.
>
--
Chen Gang
Open, share, and attitude like air, water, and life which God blessed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-10-04 11:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-04 10:00 [PATCH] drivers/net/can/m_can/Kconfig: Let CAN_M_CAN depend on HAS_IOMEM Chen Gang
2014-10-04 11:05 ` Varka Bhadram
2014-10-04 11:49 ` Chen Gang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).