From: Claudiu Manoil <claudiu.manoil@freescale.com>
To: David Miller <davem@davemloft.net>
Cc: <netdev@vger.kernel.org>, <Li.Xiubo@freescale.com>,
<Shruti@freescale.com>
Subject: Re: [net 0/8] gianfar: ARM port driver updates (1/2)
Date: Mon, 6 Oct 2014 10:55:42 +0300 [thread overview]
Message-ID: <54324AFE.1040803@freescale.com> (raw)
In-Reply-To: <20141005.212722.1867743289839811370.davem@davemloft.net>
On 10/6/2014 4:27 AM, David Miller wrote:
> From: Claudiu Manoil <claudiu.manoil@freescale.com>
> Date: Fri, 3 Oct 2014 19:02:41 +0300
>
>> This is the first round of driver protability fixes and clean-up
>> with the main purpose to make gianfar portable on ARM, for the ARM
>> based SoC that integrates the eTSEC ethernet controller - "ls1021a".
>> The patches primarily address compile time errors, when compiling
>> gianfar on ARM. They replace PPC specific functions and macros
>> with architecture independent ones, solve arch specific header
>> inclusions, guard code that relates to PPC only, and even address
>> some simple endianess issues (see MAC address setup patch).
>> The patches addressing the bulk of remaining endianess issues,
>> like handling DMA fields (BD and FCB), will follow with the sencond
>> round.
>> These patches were verified on the ls1021a SoC.
>
> If more endianness fixes are necessary and "will follow with the
> second round", I do not see how you could have verified specifically
> these changes on the ls1021a.
>
Hi David,
What I did is to split the initial patchset in 2, to ease up the review
process.
This first part is fairly straightforward, these patches make localized
code changes and can be more easily ported among different kernel
versions. The second part has fewer patches but touches more code,
because it handles endianess conversions for all the reads/writes to
the buffer descriptors. Please let me now if you have objections to
this approach.
As for testing, we have our internal kernel tree for ARM supporting
ls1021a, and these gianfar patches have been there for a while and
tested. Now it's time to upstream (a cleaned-up version of) them.
(see git.freescale.com/git/cgit.cgi/layerscape/ls1021a/linux.git/)
Please note that the current (upstream) net tree does not include the
support for ls1021a (which is to be propagated via the arm tree).
Thanks and regards,
Claudiu
next prev parent reply other threads:[~2014-10-06 7:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-03 16:02 [net 0/8] gianfar: ARM port driver updates (1/2) Claudiu Manoil
2014-10-03 16:02 ` [net 1/8] net/fsl_pq_mdio: Fix asm/ucc.h compile error for ARM Claudiu Manoil
2014-10-03 18:39 ` Sergei Shtylyov
2014-10-03 16:02 ` [net 2/8] net/fsl_pq_mdio: Use ioread/iowrite32be() portable accessors Claudiu Manoil
2014-10-03 16:02 ` [net 3/8] net/fsl_pq_mdio: Replace spin_event_timeout() with arch independent Claudiu Manoil
2014-10-03 16:02 ` [net 4/8] gianfar: Include missing headers for ARM builds Claudiu Manoil
2014-10-03 16:02 ` [net 5/8] gianfar: Exclude PPC specific errata handling from " Claudiu Manoil
2014-10-03 16:02 ` [net 6/8] gianfar: Make MAC addr setup endian safe, cleanup Claudiu Manoil
2014-10-03 16:02 ` [net 7/8] gianfar: Replace spin_event_timeout() with arch independent Claudiu Manoil
2014-10-03 16:02 ` [net 8/8] gianfar: Replace eieio with wmb for non-PPC archs Claudiu Manoil
2014-10-03 21:20 ` [net 0/8] gianfar: ARM port driver updates (1/2) Kim Phillips
2014-10-06 1:27 ` David Miller
2014-10-06 7:55 ` Claudiu Manoil [this message]
2014-10-06 19:07 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54324AFE.1040803@freescale.com \
--to=claudiu.manoil@freescale.com \
--cc=Li.Xiubo@freescale.com \
--cc=Shruti@freescale.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).