From: Rick Jones <rick.jones2@hp.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Prashant Sreedharan <prashant@broadcom.com>
Cc: davem@davemloft.net, netdev@vger.kernel.org, dborkman@redhat.com,
mchan@broadcom.com
Subject: Re: [PATCH net-next] tg3: Add skb->xmit_more support
Date: Mon, 13 Oct 2014 10:14:17 -0700 [thread overview]
Message-ID: <543C0869.7000604@hp.com> (raw)
In-Reply-To: <1413218934.9362.104.camel@edumazet-glaptop2.roam.corp.google.com>
On 10/13/2014 09:48 AM, Eric Dumazet wrote:
> On Mon, 2014-10-13 at 09:21 -0700, Prashant Sreedharan wrote:
>> Ring TX doorbell only if xmit_more is not set or the queue is stopped.
>>
>> Suggested-by: Daniel Borkmann <dborkman@redhat.com>
>> Signed-off-by: Prashant Sreedharan <prashant@broadcom.com>
>> Signed-off-by: Michael Chan <mchan@broadcom.com>
>> ---
>> drivers/net/ethernet/broadcom/tg3.c | 10 ++++++----
>> 1 files changed, 6 insertions(+), 4 deletions(-)
>
> Have you noticed any performance change ?
>
> I did the patch for bnx2x but got no real difference...
If ringing the doorbell is just a pio write, it may just get lost in the
noise. If though the programming model (or some sort of defect
workaround) of the NIC requires a pio read of some sort when ringing the
doorbell...
rick
next prev parent reply other threads:[~2014-10-13 17:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-13 16:21 [PATCH net-next] tg3: Add skb->xmit_more support Prashant Sreedharan
2014-10-13 16:48 ` Eric Dumazet
2014-10-13 17:14 ` Rick Jones [this message]
2014-10-13 17:38 ` Florian Westphal
2014-10-13 18:01 ` Florian Westphal
2014-10-14 19:34 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543C0869.7000604@hp.com \
--to=rick.jones2@hp.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=eric.dumazet@gmail.com \
--cc=mchan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=prashant@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).