From: dom <dominic.curran@citrix.com>
To: <donald.c.skidmore@intel.com>, <netdev@vger.kernel.org>
Subject: ixgbe: Question about Flow Control on 10G
Date: Tue, 14 Oct 2014 12:01:18 -0700 [thread overview]
Message-ID: <543D72FE.9090107@citrix.com> (raw)
Hi
I have a question about the ixgbe driver's handling of 'ethtool -a ethX'
when the NIC is using fibre.
Specifically I don't understand the code introduced by this commit:
commit 73d80953dfd1d5a92948005798c857c311c2834b
Author: Don Skidmore <donald.c.skidmore@intel.com>
Date: Wed Jul 31 02:19:24 2013 +0000
Subject: ixgbe: fix fc autoneg ethtool reporting.
The function introduced the function:
ixgbe_device_supports_autoneg_fc()
which gets called by ixgbe_get_pauseparam()/ixgbe_set_pauseparam().
specifically there is a case in ixgbe_device_supports_autoneg_fc()
case ixgbe_media_type_fiber_qsfp:
case ixgbe_media_type_fiber:
hw->mac.ops.check_link(hw, &speed, &link_up, false);
/* if link is down, assume supported */
if (link_up)
supported = speed == IXGBE_LINK_SPEED_1GB_FULL ?
true : false;
If link_up=1 then why is supported only true for a
speed=IXGBE_LINK_SPEED_1GB_FULL ?
Why is Flow Control not supported for IXGBE_LINK_SPEED_10GB_FULL ?
I have search through the 82599 spec, but I can't find a reason.
Please can anyone help me understand ?
Thanks
dom
next reply other threads:[~2014-10-14 19:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-14 19:01 dom [this message]
2014-10-14 20:54 ` ixgbe: Question about Flow Control on 10G Tantilov, Emil S
2014-10-15 18:56 ` dom
2014-10-15 23:46 ` Tantilov, Emil S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543D72FE.9090107@citrix.com \
--to=dominic.curran@citrix.com \
--cc=donald.c.skidmore@intel.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).