From: David L Stevens <david.stevens@oracle.com>
To: Sowmini Varadhan <sowmini.varadhan@oracle.com>,
davem@davemloft.net, bob.picco@oracle.com,
dwight.engen@oracle.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCHv3 RFC net-next 2/4] sunvnet: Use RCU to synchronize port usage with vnet_port_remove()
Date: Wed, 15 Oct 2014 12:53:42 -0400 [thread overview]
Message-ID: <543EA696.3010607@oracle.com> (raw)
In-Reply-To: <20141015164303.GC11840@oracle.com>
On 10/15/2014 12:43 PM, Sowmini Varadhan wrote:
>
> @@ -1000,6 +1003,7 @@ static int vnet_start_xmit(struct sk_buff *skb, struct net_device *dev)
...
> #if IS_ENABLED(CONFIG_IPV6)
> - else if (skb->protocol == htons(ETH_P_IPV6))
> + else if (skb->protocol == htons(ETH_P_IPV6)) {
> + rcu_read_unlock();
> icmpv6_send(skb, ICMPV6_PKT_TOOBIG, 0, localmtu);
> + }
> #endif
> goto out_dropped;
> }
I don't think you want this one; "out_dropped" does this already:
>
> out_dropped:
...
> del_timer(&port->clean_timer);
> + if (port)
> + rcu_read_unlock();
> + if (skb)
> + dev_kfree_skb(skb);
> + vnet_free_skbs(freeskbs);
> dev->stats.tx_dropped++;
> return NETDEV_TX_OK;
> }
+-DLS
prev parent reply other threads:[~2014-10-15 16:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-15 16:43 [PATCHv3 RFC net-next 2/4] sunvnet: Use RCU to synchronize port usage with vnet_port_remove() Sowmini Varadhan
2014-10-15 16:53 ` David L Stevens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=543EA696.3010607@oracle.com \
--to=david.stevens@oracle.com \
--cc=bob.picco@oracle.com \
--cc=davem@davemloft.net \
--cc=dwight.engen@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=sowmini.varadhan@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).