From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Varka Bhadram <varkabhadram@gmail.com>, netdev@vger.kernel.org
Cc: Varka Bhadram <varkab@cdac.in>
Subject: Re: [PATCH net-next 5/6] ethernet: renesas: remove unnecessary check
Date: Wed, 22 Oct 2014 15:47:43 +0400 [thread overview]
Message-ID: <5447995F.5080602@cogentembedded.com> (raw)
In-Reply-To: <1413951386-29645-6-git-send-email-varkab@cdac.in>
On 10/22/2014 8:16 AM, Varka Bhadram wrote:
> devm_ioremap_resource checks platform_get_resource() return value.
> We can remove the duplicate check here.
> Signed-off-by: Varka Bhadram <varkab@cdac.in>
> ---
> drivers/net/ethernet/renesas/sh_eth.c | 4 ----
> 1 file changed, 4 deletions(-)
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 60e9c2c..d824ba5 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -2769,10 +2769,6 @@ static int sh_eth_drv_probe(struct platform_device *pdev)
>
> /* get base addr */
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - if (unlikely(res == NULL)) {
> - dev_err(&pdev->dev, "invalid resource\n");
> - return -EINVAL;
> - }
The driver dereferences 'res' further on, so you can't remove this check.
WBR, Sergei
next prev parent reply other threads:[~2014-10-22 11:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <N>
2014-10-22 4:16 ` [PATCH net-next 0/6] cleanup on resource check Varka Bhadram
2014-10-22 4:16 ` [PATCH net-next 1/6] ethernet: wiznet: remove unnecessary check Varka Bhadram
2014-10-22 11:43 ` Sergei Shtylyov
2014-10-22 12:23 ` Varka Bhadram
2014-10-22 4:16 ` [PATCH net-next 2/6] " Varka Bhadram
2014-10-22 11:44 ` Sergei Shtylyov
2014-10-22 12:24 ` Varka Bhadram
2014-10-22 4:16 ` [PATCH net-next 3/6] ethernet: apm: xgene: " Varka Bhadram
2014-10-22 4:16 ` [PATCH net-next 4/6] ethernet: marvell: " Varka Bhadram
2014-10-22 4:16 ` [PATCH net-next 5/6] ethernet: renesas: " Varka Bhadram
2014-10-22 11:47 ` Sergei Shtylyov [this message]
2014-10-22 12:22 ` Varka Bhadram
2014-10-22 4:16 ` [PATCH net-next 6/6] ethernet: samsung: sxgbe: " Varka Bhadram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5447995F.5080602@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=netdev@vger.kernel.org \
--cc=varkab@cdac.in \
--cc=varkabhadram@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).