From: David Vrabel <david.vrabel@citrix.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: <netdev@vger.kernel.org>, <xen-devel@lists.xenproject.org>,
Ian Campbell <ian.campbell@citrix.com>
Subject: Re: [PATCH 1/3] xen-netback: make feature-rx-notify mandatory
Date: Thu, 23 Oct 2014 12:37:54 +0100 [thread overview]
Message-ID: <5448E892.9010307@citrix.com> (raw)
In-Reply-To: <20141023113206.GF9188@zion.uk.xensource.com>
On 23/10/14 12:32, Wei Liu wrote:
> On Thu, Oct 23, 2014 at 12:16:29PM +0100, Wei Liu wrote:
>> On Wed, Oct 22, 2014 at 02:08:53PM +0100, David Vrabel wrote:
>>> Frontends that do not provide feature-rx-notify may stall because
>>> netback depends on the notification from frontend to wake the guest Rx
>>> thread (even if can_queue is false).
>>>
>>> This could be fixed but feature-rx-notify was introduced in 2006 and I
>>> am not aware of any frontends that do not implement this.
>>>
>>> Signed-off-by: David Vrabel <david.vrabel@citrix.com>
>>
>> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> While I can understand this patch by itself, can you elaborate a little
> bit on how it affects later patches? Because what I'm thinking is that
> this patch is not for stable while other two should go to stable.
>From the cover letter:
"The first patch is a prerequite. Removing support for frontends with
feature-rx-notify makes it easier to reason about the correctness of
netback since it no longer has to support this outdated and broken
mode."
The other patches do not meet the stable kernel requirements (they're
too long one thing).
David
next prev parent reply other threads:[~2014-10-23 11:37 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 13:08 [PATCHv1 0/3 net-next] xen-netback: guest Rx queue drain and stall fixes David Vrabel
2014-10-22 13:08 ` [PATCH 1/3] xen-netback: make feature-rx-notify mandatory David Vrabel
2014-10-23 11:16 ` Wei Liu
2014-10-23 11:32 ` Wei Liu
2014-10-23 11:37 ` David Vrabel [this message]
2014-10-23 11:44 ` Wei Liu
2014-10-23 11:52 ` David Vrabel
2014-10-22 13:08 ` [PATCH 2/3] xen-netback: fix unlimited guest Rx internal queue and carrier flapping David Vrabel
2014-10-23 11:40 ` Wei Liu
2014-10-22 13:08 ` [PATCH 3/3] xen-netback: reintroduce guest Rx stall detection David Vrabel
2014-10-23 11:49 ` Wei Liu
2014-10-25 18:14 ` [PATCHv1 0/3 net-next] xen-netback: guest Rx queue drain and stall fixes David Miller
2014-10-25 18:17 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5448E892.9010307@citrix.com \
--to=david.vrabel@citrix.com \
--cc=ian.campbell@citrix.com \
--cc=netdev@vger.kernel.org \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).