From mboxrd@z Thu Jan 1 00:00:00 1970 From: Guenter Roeck Subject: Re: [PATCH 06/14] net: dsa: Add support for hardware monitoring Date: Thu, 23 Oct 2014 23:09:33 -0700 Message-ID: <5449ED1D.9020102@roeck-us.net> References: <1414037002-25528-7-git-send-email-linux@roeck-us.net> <54488CE1.2000106@roeck-us.net> <20141024.010306.1939269479587208896.davem@davemloft.net> <5449E66B.6090902@roeck-us.net> <544A4B8C.5040002@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: QUOTED-PRINTABLE Cc: netdev@vger.kernel.org, andrew@lunn.ch, linux-kernel@vger.kernel.org To: Florian Fainelli , David Miller Return-path: In-Reply-To: <544A4B8C.5040002@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 10/24/2014 05:52 AM, Florian Fainelli wrote: > Le 23/10/2014 22:40, Guenter Roeck a =E9crit : >> On 10/23/2014 10:03 PM, David Miller wrote: >>> From: Guenter Roeck >>> Date: Wed, 22 Oct 2014 22:06:41 -0700 >>> >>>> On 10/22/2014 09:37 PM, Florian Fainelli wrote: >>>>> 2014-10-22 21:03 GMT-07:00 Guenter Roeck : >>>>>> Some Marvell switches provide chip temperature data. >>>>>> Add support for reporting it to the dsa infrastructure. >>>>>> >>>>>> Signed-off-by: Guenter Roeck >>>>>> --- >>>>> [snip] >>>>> >>>>>> +/* hwmon support >>>>>> ************************************************************/ >>>>>> + >>>>>> +#if defined(CONFIG_HWMON) || (defined(MODULE) && >>>>>> defined(CONFIG_HWMON_MODULE)) >>>>> >>>>> IS_ENABLED(CONFIG_HWMON)? >>>>> >>>> >>>> Hi Florian, >>>> >>>> unfortunately, that won't work; I had it initially and got a nice >>>> error message >>>> from Fengguang's build test bot. >>> >>> Then the Kconfig dependencies are broken. >>> >>> Fix Kconfig to only allow legal combinations. >>> >> >> I see two options for that: >> >> - Add >> select HWMON >> to the NET_DSA Kconfig entry. >> Example is Broadcom TIGON3 driver. >> >> - Add a DSA_HWMON Kconfig entry to define the dependencies and >> to let the user select if the functionality should be enabled. >> Example is Intel IGB driver. >> >> Any preference from your side ? If no, I'll go with the latter. > > I would prefer DSA_HWMON personaly, though no strong feelings. That is what I ended up implementing. NET_DSA_HWMON, actually, for cons= istency. Since this is the most debated patch in this patch set, how about you d= rop it from your v2 and we sort this one out separately? We can do that if there are still issues in v2. Thanks, Guenter