From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, davem@davemloft.net
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2 2/2] dsa: mv88e6171: Fix tagging protocol/Kconfig
Date: Fri, 24 Oct 2014 15:45:13 -0700 [thread overview]
Message-ID: <544AD679.9020003@gmail.com> (raw)
In-Reply-To: <1414187045-8326-3-git-send-email-andrew@lunn.ch>
On 10/24/2014 02:44 PM, Andrew Lunn wrote:
> The mv88e6171 can support two different tagging protocols, DSA and
> EDSA. The switch driver structure only allows one protocol to be
> enumerated, and DSA was chosen. However the Kconfig entry ensures the
> EDSA tagging code is built. With a minimal configuration, we then end
> up with a mismatch. The probe is successful, EDSA tagging is used, but
> the switch is configured for DSA, resulting in mangled packets.
>
> Change the switch driver structure to enumerate EDSA, fixing the
> mismatch.
>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> Fixes: 42f272539487 ("net: DSA: Marvell mv88e6171 switch driver")
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/net/dsa/mv88e6171.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/net/dsa/mv88e6171.c b/drivers/net/dsa/mv88e6171.c
> index 1020a7af67cf..78d8e876f3aa 100644
> --- a/drivers/net/dsa/mv88e6171.c
> +++ b/drivers/net/dsa/mv88e6171.c
> @@ -395,7 +395,7 @@ static int mv88e6171_get_sset_count(struct dsa_switch *ds)
> }
>
> struct dsa_switch_driver mv88e6171_switch_driver = {
> - .tag_protocol = DSA_TAG_PROTO_DSA,
> + .tag_protocol = DSA_TAG_PROTO_EDSA,
> .priv_size = sizeof(struct mv88e6xxx_priv_state),
> .probe = mv88e6171_probe,
> .setup = mv88e6171_setup,
>
next prev parent reply other threads:[~2014-10-24 22:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-24 21:44 [PATCH v2 0/2] DSA tagging mismatches Andrew Lunn
2014-10-24 21:44 ` [PATCH v2 1/2] net: dsa: Error out on tagging protocol mismatches Andrew Lunn
2014-10-24 22:42 ` Florian Fainelli
2014-10-24 21:44 ` [PATCH v2 2/2] dsa: mv88e6171: Fix tagging protocol/Kconfig Andrew Lunn
2014-10-24 22:45 ` Florian Fainelli [this message]
2014-10-28 19:28 ` [PATCH v2 0/2] DSA tagging mismatches David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544AD679.9020003@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).