* [PATCH] skbuff.h: fix kernel-doc warning for headers_end
@ 2014-10-27 2:14 Randy Dunlap
2014-10-28 21:02 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2014-10-27 2:14 UTC (permalink / raw)
To: netdev@vger.kernel.org, David Miller
From: Randy Dunlap <rdunlap@infradead.org>
Fix kernel-doc warning in <linux/skbuff.h> by making both headers_start
and headers_end private fields.
Warning(..//include/linux/skbuff.h:654): No description found for parameter 'headers_end[0]'
Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
---
include/linux/skbuff.h | 4 ++++
1 file changed, 4 insertions(+)
Or I can document those two fields if you would rather not have them
marked as private...
--- lnx-318-rc2.orig/include/linux/skbuff.h
+++ lnx-318-rc2/include/linux/skbuff.h
@@ -557,7 +557,9 @@ struct sk_buff {
/* fields enclosed in headers_start/headers_end are copied
* using a single memcpy() in __copy_skb_header()
*/
+ /* private: */
__u32 headers_start[0];
+ /* public: */
/* if you move pkt_type around you also must adapt those constants */
#ifdef __BIG_ENDIAN_BITFIELD
@@ -642,7 +644,9 @@ struct sk_buff {
__u16 network_header;
__u16 mac_header;
+ /* private: */
__u32 headers_end[0];
+ /* public: */
/* These elements must be at the end, see alloc_skb() for details. */
sk_buff_data_t tail;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] skbuff.h: fix kernel-doc warning for headers_end
2014-10-27 2:14 [PATCH] skbuff.h: fix kernel-doc warning for headers_end Randy Dunlap
@ 2014-10-28 21:02 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2014-10-28 21:02 UTC (permalink / raw)
To: rdunlap; +Cc: netdev
From: Randy Dunlap <rdunlap@infradead.org>
Date: Sun, 26 Oct 2014 19:14:06 -0700
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix kernel-doc warning in <linux/skbuff.h> by making both headers_start
> and headers_end private fields.
>
> Warning(..//include/linux/skbuff.h:654): No description found for parameter 'headers_end[0]'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
Applied, thanks a lot Randy.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2014-10-28 21:02 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-10-27 2:14 [PATCH] skbuff.h: fix kernel-doc warning for headers_end Randy Dunlap
2014-10-28 21:02 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).