From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: Eric Dumazet <eric.dumazet@gmail.com>,
David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, Herbert Xu <herbert@gondor.apana.org.au>
Subject: Re: [PATCH net-next] net: skb_segment() should preserve backpressure
Date: Tue, 28 Oct 2014 21:15:44 +0900 [thread overview]
Message-ID: <544F88F0.7090706@lab.ntt.co.jp> (raw)
In-Reply-To: <1414431051.16231.23.camel@edumazet-glaptop2.roam.corp.google.com>
On 2014/10/28 2:30, Eric Dumazet wrote:
> From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
>
> This patch generalizes commit d6a4a1041176 ("tcp: GSO should be TSQ
> friendly") to protocols using skb_set_owner_w()
>
> TCP uses its own destructor (tcp_wfree) and needs a more complex scheme
> as explained in commit 6ff50cd55545 ("tcp: gso: do not generate out of
> order packets")
>
> This allows UDP sockets using UFO to get proper backpressure,
> thus avoiding qdisc drops and excessive cpu usage.
>
...
> [edumazet] Rewrote patch and changelog.
This looks better in performance.
I tested this patch and couldn't find any problem.
Thank you for your reviewing and suggesting,
Toshiaki Makita
next prev parent reply other threads:[~2014-10-28 12:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-27 10:29 Poor UDP throughput with virtual devices and UFO Toshiaki Makita
2014-10-27 15:01 ` Eric Dumazet
2014-10-27 15:39 ` Eric Dumazet
2014-10-27 17:30 ` [PATCH net-next] net: skb_segment() should preserve backpressure Eric Dumazet
2014-10-28 12:15 ` Toshiaki Makita [this message]
2014-10-29 18:47 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=544F88F0.7090706@lab.ntt.co.jp \
--to=makita.toshiaki@lab.ntt.co.jp \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).