From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: antoine.tenart@free-electrons.com, f.fainelli@gmail.com,
eric.y.miao@gmail.com, haojian.zhuang@gmail.com,
linux-arm-kernel@lists.infradead.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fixup! net: pxa168_eth: Provide phy_interface mode on platform_data
Date: Tue, 28 Oct 2014 22:11:09 +0100 [thread overview]
Message-ID: <5450066D.2010600@gmail.com> (raw)
In-Reply-To: <20141028.164939.509353257563688482.davem@davemloft.net>
On 28.10.2014 21:49, David Miller wrote:
> From: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
> Date: Sat, 25 Oct 2014 12:08:59 +0200
>
>> Do not add phy include to the board file but platform_data include
>> instead.
>>
>> Signed-off-by: Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
>> ---
>> David,
>>
>> I should have compile tested this patch earlier. I did now on
>> pxa168_defconfig right after I received an 0-day kbuild error
>> on this patch.
>>
>> This is the corresponding fix, can you please squash it in?
>>
>> Thanks and sorry for the noise,
>
> Patch applied to net-next, but:
>
> 1) There is never any way for me to "squash" a patch into an old
> one. Once I apply a patch it is a permanent commit in my tree
> and cannot be undone and/or modified.
>
> Therefore the only thing you can do is send me a relative fix
> and that's what shows up in my tree as yet another later commit.
Ok, good to know and sorry for the crippled fixup patch. I was assuming
that net-next is also rebased until pulled/moved to some stable state.
> 2) Always be specific about the target tree in you subject,
> line. Never assume I can figure it out by context.
Also, sorry for the little information given.
Thanks,
Sebastian
next prev parent reply other threads:[~2014-10-28 21:11 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-22 18:26 [PATCH v2 0/9] Marvell PXA168 libphy handling and Berlin Ethernet Sebastian Hesselbarth
2014-10-22 18:26 ` [PATCH v2 1/9] phy: marvell: Add support for 88E3016 FastEthernet PHY Sebastian Hesselbarth
2014-10-22 18:26 ` [PATCH v2 2/9] net: pxa168_eth: Provide phy_interface mode on platform_data Sebastian Hesselbarth
2014-10-25 10:08 ` [PATCH] fixup! " Sebastian Hesselbarth
2014-10-28 20:49 ` David Miller
2014-10-28 21:11 ` Sebastian Hesselbarth [this message]
2014-10-22 18:26 ` [PATCH v2 3/9] net: pxa168_eth: Prepare proper libphy handling Sebastian Hesselbarth
2014-10-22 18:26 ` [PATCH v2 4/9] net: pxa168_eth: Remove HW auto-negotiaion Sebastian Hesselbarth
2014-10-22 18:26 ` [PATCH v2 5/9] net: pxa168_eth: Remove in-driver PHY mangling Sebastian Hesselbarth
[not found] ` <1414002412-13615-1-git-send-email-sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-22 18:26 ` [PATCH v2 6/9] ARM: berlin: Add BG2 ethernet DT nodes Sebastian Hesselbarth
2014-10-29 18:38 ` Sebastian Hesselbarth
2014-10-22 18:26 ` [PATCH v2 7/9] ARM: berlin: Add BG2CD " Sebastian Hesselbarth
2014-10-22 18:26 ` [PATCH v2 8/9] ARM: berlin: Add phy-connection-type to BG2Q Ethernet Sebastian Hesselbarth
2014-10-22 18:26 ` [PATCH v2 9/9] ARM: berlin: Enable ethernet on Sony NSZ-GS7 Sebastian Hesselbarth
2014-10-24 19:50 ` [PATCH v2 0/9] Marvell PXA168 libphy handling and Berlin Ethernet David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5450066D.2010600@gmail.com \
--to=sebastian.hesselbarth@gmail.com \
--cc=antoine.tenart@free-electrons.com \
--cc=davem@davemloft.net \
--cc=eric.y.miao@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=haojian.zhuang@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).