From: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
To: Larry Finger <Larry.Finger@lwfinger.net>, linville@tuxdriver.com
Cc: linux-wireless@vger.kernel.org, troy_tan@realsil.com.cn,
netdev@vger.kernel.org, Mike Galbraith <umgwanakikbuti@gmail.com>,
Thadeu Cascardo <cascardo@cascardo.eti.br>
Subject: Re: [PATCH V3.18] rtlwifi: Add check for get_btc_status callback
Date: Tue, 28 Oct 2014 23:43:44 -0200 [thread overview]
Message-ID: <54504650.6060905@gmail.com> (raw)
In-Reply-To: <1414081629-23002-1-git-send-email-Larry.Finger@lwfinger.net>
On 10/23/2014 02:27 PM, Larry Finger wrote:
> Drivers that do not use the get_btc_status() callback may not define a
> dummy routine. The caller needs to check before making the call.
>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Murilo Opsfelder Araujo <mopsfelder@gmail.com>
> Cc: Mike Galbraith <umgwanakikbuti@gmail.com>
> Cc: Thadeu Cascardo <cascardo@cascardo.eti.br>
> ---
>
> John,
>
> This missing statement is causing kernel crashes for several of the drivers.
> This patch should be applied ASAP.
>
> Larry
> ---
>
> drivers/net/wireless/rtlwifi/pci.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
> index 667aba8..25daa87 100644
> --- a/drivers/net/wireless/rtlwifi/pci.c
> +++ b/drivers/net/wireless/rtlwifi/pci.c
> @@ -1796,7 +1796,8 @@ static int rtl_pci_start(struct ieee80211_hw *hw)
> rtl_pci_reset_trx_ring(hw);
>
> rtlpci->driver_is_goingto_unload = false;
> - if (rtlpriv->cfg->ops->get_btc_status()) {
> + if (rtlpriv->cfg->ops->get_btc_status &&
> + rtlpriv->cfg->ops->get_btc_status()) {
> rtlpriv->btcoexist.btc_ops->btc_init_variables(rtlpriv);
> rtlpriv->btcoexist.btc_ops->btc_init_hal_vars(rtlpriv);
> }
>
Hi, Larry & everyone.
This patch didn't solve and next-20141028 is still crashing on my laptop
with rtl8192se device:
http://opsfelder.com/~murilo/lkml/next-20141028_crashing.jpg
--
Murilo
prev parent reply other threads:[~2014-10-29 1:45 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-10-23 16:27 [PATCH V3.18] rtlwifi: Add check for get_btc_status callback Larry Finger
2014-10-23 18:08 ` Mike Galbraith
2014-10-23 18:23 ` Larry Finger
2014-10-24 2:09 ` Mike Galbraith
2014-10-24 16:39 ` Larry Finger
2014-10-24 18:13 ` Murilo Opsfelder Araujo
[not found] ` <544A96C0.8030107-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-10-24 19:09 ` Murilo Opsfelder Araujo
2014-10-25 2:57 ` Mike Galbraith
2014-10-23 18:26 ` Murilo Opsfelder Araujo
2014-10-29 1:43 ` Murilo Opsfelder Araujo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54504650.6060905@gmail.com \
--to=mopsfelder@gmail.com \
--cc=Larry.Finger@lwfinger.net \
--cc=cascardo@cascardo.eti.br \
--cc=linux-wireless@vger.kernel.org \
--cc=linville@tuxdriver.com \
--cc=netdev@vger.kernel.org \
--cc=troy_tan@realsil.com.cn \
--cc=umgwanakikbuti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).