From: Marcelo Ricardo Leitner <mleitner@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH net] vxlan: Do not reuse sockets for a different address family
Date: Tue, 04 Nov 2014 14:56:33 -0200 [thread overview]
Message-ID: <54590541.8050308@redhat.com> (raw)
In-Reply-To: <20141104.113203.432907272611801931.davem@davemloft.net>
On 04-11-2014 14:32, David Miller wrote:
> From: Marcelo Ricardo Leitner <mleitner@redhat.com>
> Date: Tue, 4 Nov 2014 11:46:49 -0200
>
>> hlist_for_each_entry_rcu(vs, vs_head(net, port), hlist) {
>> - if (inet_sk(vs->sock->sk)->inet_sport == port)
>> + if ((inet_sk(vs->sock->sk)->inet_sport == port) &&
>> + (inet_sk(vs->sock->sk)->sk.sk_family == family))
>
> This is not indented properly.
>
> For a multi-line conditional, the second and subsequent lines
> should start precisely at the first column after the openning
> parenthesis on the first line.
>
> You must use the appropriate number of TAB and SPACE characters
> necessary to achieve this. If you are only using TAB characters, you
> are most likely doing it wrong.
Yes.. I forgot to switch profiles, was using tab spacing=4, then it was
aligned and I didn't notice it.
> Please fix this up and resubmit, thanks.
Okay, sorry. Thanks David, Sergei.
Marcelo
prev parent reply other threads:[~2014-11-04 16:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 13:46 [PATCH net] vxlan: Do not reuse sockets for a different address family Marcelo Ricardo Leitner
2014-11-04 16:25 ` Sergei Shtylyov
2014-11-04 16:32 ` David Miller
2014-11-04 16:56 ` Marcelo Ricardo Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54590541.8050308@redhat.com \
--to=mleitner@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).