* [PATCH] net: phy: spi_ks8995: remove sysfs bin file by registered attribute
@ 2014-11-03 23:25 Vladimir Zapolskiy
2014-11-04 18:15 ` Florian Fainelli
2014-11-04 22:19 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Vladimir Zapolskiy @ 2014-11-03 23:25 UTC (permalink / raw)
To: netdev; +Cc: Florian Fainelli, David S. Miller
When a sysfs binary file is asked to be removed, it is found by
attribute name, so strictly speaking this change is not a fix, but
just in case when attribute name is changed in the driver or sysfs
internals are changed, it might be better to remove the previously
created file using right the same binary attribute.
Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Cc: Florian Fainelli <f.fainelli@gmail.com>
Cc: David S. Miller <davem@davemloft.net>
---
drivers/net/phy/spi_ks8995.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c
index eab57fc..4653015 100644
--- a/drivers/net/phy/spi_ks8995.c
+++ b/drivers/net/phy/spi_ks8995.c
@@ -353,7 +353,9 @@ static int ks8995_probe(struct spi_device *spi)
static int ks8995_remove(struct spi_device *spi)
{
- sysfs_remove_bin_file(&spi->dev.kobj, &ks8995_registers_attr);
+ struct ks8995_switch *ks = spi_get_drvdata(spi);
+
+ sysfs_remove_bin_file(&spi->dev.kobj, &ks->regs_attr);
return 0;
}
--
1.7.10.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] net: phy: spi_ks8995: remove sysfs bin file by registered attribute
2014-11-03 23:25 [PATCH] net: phy: spi_ks8995: remove sysfs bin file by registered attribute Vladimir Zapolskiy
@ 2014-11-04 18:15 ` Florian Fainelli
2014-11-04 22:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Florian Fainelli @ 2014-11-04 18:15 UTC (permalink / raw)
To: Vladimir Zapolskiy, netdev; +Cc: David S. Miller
On 11/03/2014 03:25 PM, Vladimir Zapolskiy wrote:
> When a sysfs binary file is asked to be removed, it is found by
> attribute name, so strictly speaking this change is not a fix, but
> just in case when attribute name is changed in the driver or sysfs
> internals are changed, it might be better to remove the previously
> created file using right the same binary attribute.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
> Cc: Florian Fainelli <f.fainelli@gmail.com>
> Cc: David S. Miller <davem@davemloft.net>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
> ---
> drivers/net/phy/spi_ks8995.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/phy/spi_ks8995.c b/drivers/net/phy/spi_ks8995.c
> index eab57fc..4653015 100644
> --- a/drivers/net/phy/spi_ks8995.c
> +++ b/drivers/net/phy/spi_ks8995.c
> @@ -353,7 +353,9 @@ static int ks8995_probe(struct spi_device *spi)
>
> static int ks8995_remove(struct spi_device *spi)
> {
> - sysfs_remove_bin_file(&spi->dev.kobj, &ks8995_registers_attr);
> + struct ks8995_switch *ks = spi_get_drvdata(spi);
> +
> + sysfs_remove_bin_file(&spi->dev.kobj, &ks->regs_attr);
>
> return 0;
> }
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] net: phy: spi_ks8995: remove sysfs bin file by registered attribute
2014-11-03 23:25 [PATCH] net: phy: spi_ks8995: remove sysfs bin file by registered attribute Vladimir Zapolskiy
2014-11-04 18:15 ` Florian Fainelli
@ 2014-11-04 22:19 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2014-11-04 22:19 UTC (permalink / raw)
To: vz; +Cc: netdev, f.fainelli
From: Vladimir Zapolskiy <vz@mleia.com>
Date: Tue, 4 Nov 2014 01:25:09 +0200
> When a sysfs binary file is asked to be removed, it is found by
> attribute name, so strictly speaking this change is not a fix, but
> just in case when attribute name is changed in the driver or sysfs
> internals are changed, it might be better to remove the previously
> created file using right the same binary attribute.
>
> Signed-off-by: Vladimir Zapolskiy <vz@mleia.com>
Applied to net-next, thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-11-04 22:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-03 23:25 [PATCH] net: phy: spi_ks8995: remove sysfs bin file by registered attribute Vladimir Zapolskiy
2014-11-04 18:15 ` Florian Fainelli
2014-11-04 22:19 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).