Re: [PATCH v2 5/5] stmmac: pci: remove FSF address

Re: [PATCH v2 5/5] stmmac: pci: remove FSF address

[Xose Vazquez Perez]

David Miller wrote:

> Andy Shevchenko wrote:
>> The FSF address is subject to change, thus remove it from the file.
>> 
>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> I cound 90t instances of this under drivers/net, therefore if this change is
          ^^^^^^^^^^^^^
> appropriate I'd rather someone script this and kill it across entire
> subdirectories.

It's a bit more, 555:

    134  * 51 Franklin Street, Fifth Floor, Boston, MA 02110, USA
     96  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA
     89   51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
     86  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110,
     44  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
     43   Boston, MA 02110-1301, USA.
     19  * Temple Place - Suite 330, Boston, MA  02111-1307, USA.
     10   Temple Place - Suite 330, Boston, MA  02111-1307, USA.
      8  * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA
      5  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
      5  * 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
      5 # 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
      3  * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
      2 # 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA or on the
      1  *  Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301,
      1 * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110,
      1 # Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA.
      1  * Boston, MA  02110-1301, USA.
      1  *  Boston, MA 02110-1301, USA.
      1  * 51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.

Re: [PATCH v2 5/5] stmmac: pci: remove FSF address

[David Miller]

From: Xose Vazquez Perez <xose.vazquez@gmail.com>
Date: Tue, 04 Nov 2014 21:09:41 +0100

> David Miller wrote:
> 
>> Andy Shevchenko wrote:
>>> The FSF address is subject to change, thus remove it from the file.
>>> 
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
>> 
>> I cound 90t instances of this under drivers/net, therefore if this change is
>           ^^^^^^^^^^^^^
>> appropriate I'd rather someone script this and kill it across entire
>> subdirectories.
> 
> It's a bit more, 555:

I meant "nine hundred something", the 't' it my finger slipping down
one row on my keyboard :-)

[PATCH v2 0/5] stmmac: pci: various cleanups and fixes

[Andy Shevchenko]

There are few cleanups and fixes regarding to stmmac PCI driver.
This has been tested on Intel Galileo board with recent net-next tree.

Since v1:
- remove already applied patch
- append patch 1/5
- rework patch 3/5 to be functional compatible with original code

Andy Shevchenko (5):
  stmmac: pci: use defined constant instead of magic number
  stmmac: pci: convert to use dev_pm_ops
  stmmac: pci: use managed resources
  stmmac: pci: convert to use dev_* macros
  stmmac: pci: remove FSF address

 drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 84 ++++++++----------------
 1 file changed, 26 insertions(+), 58 deletions(-)

-- 
2.1.1

[PATCH v2 5/5] stmmac: pci: remove FSF address

[Andy Shevchenko]

The FSF address is subject to change, thus remove it from the file.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
index 5084699..068ef8e 100644
--- a/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
+++ b/drivers/net/ethernet/stmicro/stmmac/stmmac_pci.c
@@ -12,10 +12,6 @@
   FITNESS FOR A PARTICULAR PURPOSE.  See the GNU General Public License for
   more details.
 
-  You should have received a copy of the GNU General Public License along with
-  this program; if not, write to the Free Software Foundation, Inc.,
-  51 Franklin St - Fifth Floor, Boston, MA 02110-1301 USA.
-
   The full GNU General Public License is included in this distribution in
   the file called "COPYING".
 
-- 
2.1.1

Re: [PATCH v2 5/5] stmmac: pci: remove FSF address

[David Miller]

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Mon,  3 Nov 2014 15:02:17 +0200

> The FSF address is subject to change, thus remove it from the file.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

I cound 90t instances of this under drivers/net, therefore if this change is
appropriate I'd rather someone script this and kill it across entire
subdirectories.

Thanks.

Re: [PATCH v2 5/5] stmmac: pci: remove FSF address

[Andy Shevchenko]

On Mon, 2014-11-03 at 15:57 -0500, David Miller wrote:
> From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Date: Mon,  3 Nov 2014 15:02:17 +0200
> 
> > The FSF address is subject to change, thus remove it from the file.
> > 
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> 
> I cound 90t instances of this under drivers/net, therefore if this change is
> appropriate 

Can't find fast the discussion, but there is the commit
4783f894d0f3bfb107cf3b1d9aed1f1a0672ee1d "checkpatch.pl: check for the
FSF mailing address".


> I'd rather someone script this and kill it across entire
> subdirectories.

I'm okay if you don't apply this patch now.


-- 
Andy Shevchenko <andriy.shevchenko@intel.com>
Intel Finland Oy

Re: [PATCH v2 5/5] stmmac: pci: remove FSF address

[David Miller]

From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Date: Tue, 04 Nov 2014 11:06:24 +0200

> On Mon, 2014-11-03 at 15:57 -0500, David Miller wrote:
>> I'd rather someone script this and kill it across entire
>> subdirectories.
> 
> I'm okay if you don't apply this patch now.

Then please resubmit this series with it ommitted, you'll have
to update your cover letter as well if the patch is mentioned
there.

Thanks.