From: Roberto Medina <robertoxmed@gmail.com>
To: David Laight <David.Laight@ACULAB.COM>, Joe Perches <joe@perches.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: eth: realtek: atp: checkpatch errors and warnings corrected
Date: Wed, 05 Nov 2014 08:44:54 +0100 [thread overview]
Message-ID: <5459D576.3010000@gmail.com> (raw)
In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1C9E71E4@AcuExch.aculab.com>
On 11/04/2014 11:19 AM, David Laight wrote:
>
> That code (and all the ones below) are gibberish, neither the old or new
> sequences make any sense.
>
Thank you for your feedback I did it again and objdiff doesn't show any
changes (if I'm not mistaken).
> Almost as though you used the wrong instruction set!
>
> David
diff -Nurd
/home/vov/Git/linux-next/.tmp_objdiff/a641d0e/drivers/net/ethernet/realtek/atp.dis
/home/vov/Git/linux-next/.tmp_objdiff/5f19b70/drivers/net/ethernet/realtek/atp.dis
---
/home/vov/Git/linux-next/.tmp_objdiff/a641d0e/drivers/net/ethernet/realtek/atp.dis
2014-11-05 08:38:49.244100507 +0100
+++
/home/vov/Git/linux-next/.tmp_objdiff/5f19b70/drivers/net/ethernet/realtek/atp.dis
2014-11-05 08:39:14.654101606 +0100
@@ -1357,7 +1357,7 @@
Disassembly of section .bss:
-00000000 <num_tx_since_rx.36127>:
+00000000 <num_tx_since_rx.36172>:
: 00 00 add %al,(%eax)
...
Thanks,
Roberto
prev parent reply other threads:[~2014-11-05 7:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-03 18:24 [PATCH] net: eth: realtek: atp: checkpatch errors and warnings corrected Roberto Medina
2014-11-03 18:51 ` Joe Perches
2014-11-03 19:09 ` Roberto Medina
2014-11-04 10:19 ` David Laight
2014-11-05 7:44 ` Roberto Medina [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5459D576.3010000@gmail.com \
--to=robertoxmed@gmail.com \
--cc=David.Laight@ACULAB.COM \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).