From: Marcelo Ricardo Leitner <mleitner@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, stephen@networkplumber.org,
sergei.shtylyov@cogentembedded.com
Subject: Re: [PATCH net v2] vxlan: Do not reuse sockets for a different address family
Date: Wed, 05 Nov 2014 19:29:40 -0200 [thread overview]
Message-ID: <545A96C4.3030106@redhat.com> (raw)
In-Reply-To: <20141105.155913.297158120451064287.davem@davemloft.net>
On 05-11-2014 18:59, David Miller wrote:
> From: Marcelo Ricardo Leitner <mleitner@redhat.com>
> Date: Tue, 4 Nov 2014 15:03:20 -0200
>
>> @@ -281,7 +281,8 @@ static struct vxlan_sock *vxlan_find_sock(struct net *net, __be16 port)
>> struct vxlan_sock *vs;
>>
>> hlist_for_each_entry_rcu(vs, vs_head(net, port), hlist) {
>> - if (inet_sk(vs->sock->sk)->inet_sport == port)
>> + if (inet_sk(vs->sock->sk)->inet_sport == port &&
>> + inet_sk(vs->sock->sk)->sk.sk_family == family)
>
> You didn't even compile this.
This patch was part of a bigger change and I really thought I had tested it by
itself, but clearly I was wrong, sorry.
(I changed the port hash to include the family in the key, and that's how that
variable got there.)
> You're in the penalty box, and I'm ignoring your patches for at least
> a week, this is really unacceptable for an upstream patch submission.
>
> Sorry.
Ack, sorry again. It was twice in a bad day, but my bad. Won't happen again.
Marcelo
prev parent reply other threads:[~2014-11-05 21:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-04 17:03 [PATCH net v2] vxlan: Do not reuse sockets for a different address family Marcelo Ricardo Leitner
2014-11-05 20:59 ` David Miller
2014-11-05 21:29 ` Marcelo Ricardo Leitner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545A96C4.3030106@redhat.com \
--to=mleitner@redhat.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).