From: Stefan Bader <stefan.bader@canonical.com>
To: Eric Dumazet <eric.dumazet@gmail.com>,
Zoltan Kiss <zoltan.kiss@linaro.org>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
David Vrabel <david.vrabel@citrix.com>,
Jay Vosburgh <jay.vosburgh@canonical.com>,
linux-kernel@vger.kernel.org, xen-devel@lists.xenproject.org
Subject: Re: [Xen-devel] BUG in xennet_make_frags with paged skb data
Date: Fri, 07 Nov 2014 13:15:59 +0100 [thread overview]
Message-ID: <545CB7FF.8080003@canonical.com> (raw)
In-Reply-To: <1415359320.13896.105.camel@edumazet-glaptop2.roam.corp.google.com>
[-- Attachment #1: Type: text/plain, Size: 948 bytes --]
On 07.11.2014 12:22, Eric Dumazet wrote:
> On Fri, 2014-11-07 at 09:25 +0000, Zoltan Kiss wrote:
>
> Please do not top post.
>
>> Hi,
>>
>> AFAIK in this scenario your skb frag is wrong. The page pointer should
>> point to the original compound page (not a member of it), and offset
>> should be set accordingly.
>> For example, if your compound page is 16K (4 page), then the page
>> pointer should point to the first page, and if the data starts at the
>> 3rd page, then offset should be >8K
>
> This is not accurate.
>
> This BUG_ON() is wrong.
>
> It should instead be :
>
> BUG_ON(len + offset > PAGE_SIZE<<compound_order(compound_head(page)));
would that not have to be
BUG_ON((page-compound_head(page)*PAGE_SIZE)+offset+len >
PAGE_SIZE<<compound_order(compound_head(page)));
since offset is adjusted to start from the tail page in that case.
>
> splice() code can generate such cases.
>
>
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
next prev parent reply other threads:[~2014-11-07 12:15 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 21:49 BUG in xennet_make_frags with paged skb data Seth Forshee
2014-11-07 9:25 ` [Xen-devel] " Zoltan Kiss
2014-11-07 11:22 ` Eric Dumazet
2014-11-07 12:15 ` Stefan Bader [this message]
2014-11-07 12:21 ` Zoltan Kiss
2014-11-07 12:28 ` Stefan Bader
2014-11-07 10:44 ` David Vrabel
2014-11-07 11:08 ` Stefan Bader
2014-11-07 14:51 ` [Xen-devel] " Zoltan Kiss
2014-11-10 14:35 ` Seth Forshee
2014-11-10 14:41 ` David Vrabel
2014-11-10 16:39 ` [Xen-devel] " Zoltan Kiss
2014-11-10 16:42 ` David Vrabel
2014-11-10 17:02 ` Eric Dumazet
2014-11-10 17:20 ` Frediano Ziglio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=545CB7FF.8080003@canonical.com \
--to=stefan.bader@canonical.com \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=david.vrabel@citrix.com \
--cc=eric.dumazet@gmail.com \
--cc=jay.vosburgh@canonical.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
--cc=zoltan.kiss@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).