From: David Vrabel <david.vrabel@citrix.com>
To: Zoltan Kiss <zoltan.kiss@linaro.org>, <netdev@vger.kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <eric.dumazet@gmail.com>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefan Bader <stefan.bader@canonical.com>,
Jay Vosburgh <jay.vosburgh@canonical.com>,
<linux-kernel@vger.kernel.org>, <xen-devel@lists.xenproject.org>
Subject: Re: [Xen-devel] BUG in xennet_make_frags with paged skb data
Date: Mon, 10 Nov 2014 16:42:25 +0000 [thread overview]
Message-ID: <5460EAF1.5020903@citrix.com> (raw)
In-Reply-To: <5460EA45.2080202@linaro.org>
On 10/11/14 16:39, Zoltan Kiss wrote:
>
> The BUG_ON suggested by Stefan would be still reasonable:
>
> BUG_ON(((page-compound_head(page))*PAGE_SIZE)+offset+len >
> PAGE_SIZE<<compound_order(compound_head(page)));
Well, it wouldn't trigger but I don't think it is useful any more.
David
next prev parent reply other threads:[~2014-11-10 16:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-06 21:49 BUG in xennet_make_frags with paged skb data Seth Forshee
2014-11-07 9:25 ` [Xen-devel] " Zoltan Kiss
2014-11-07 11:22 ` Eric Dumazet
2014-11-07 12:15 ` Stefan Bader
2014-11-07 12:21 ` Zoltan Kiss
2014-11-07 12:28 ` Stefan Bader
2014-11-07 10:44 ` David Vrabel
2014-11-07 11:08 ` Stefan Bader
2014-11-07 14:51 ` [Xen-devel] " Zoltan Kiss
2014-11-10 14:35 ` Seth Forshee
2014-11-10 14:41 ` David Vrabel
2014-11-10 16:39 ` [Xen-devel] " Zoltan Kiss
2014-11-10 16:42 ` David Vrabel [this message]
2014-11-10 17:02 ` Eric Dumazet
2014-11-10 17:20 ` Frediano Ziglio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5460EAF1.5020903@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=jay.vosburgh@canonical.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stefan.bader@canonical.com \
--cc=xen-devel@lists.xenproject.org \
--cc=zoltan.kiss@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).