From: Florian Fainelli <f.fainelli@gmail.com>
To: "Rafael J. Wysocki" <rafael@kernel.org>, Andrew Lunn <andrew@lunn.ch>
Cc: Marcin Wojtas <mw@semihalf.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
ACPI Devel Maling List <linux-acpi@vger.kernel.org>,
netdev <netdev@vger.kernel.org>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Len Brown <lenb@kernel.org>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
David Miller <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Russell King - ARM Linux <linux@armlinux.org.uk>,
Heiner Kallweit <hkallweit1@gmail.com>,
Grzegorz Bernacki <gjb@semihalf.com>,
Grzegorz Jaszczyk <jaz@semihalf.com>,
Tomasz Nowicki <tn@semihalf.com>,
Samer El-Haj-Mahmoud <Samer.El-Haj-Mahmoud@arm.com>,
upstream@semihalf.com
Subject: Re: [net-next: PATCH 08/12] ACPI: scan: prevent double enumeration of MDIO bus children
Date: Wed, 22 Jun 2022 09:12:03 -0700 [thread overview]
Message-ID: <54618c2a-e1f3-bbd0-8fb2-1669366a3b59@gmail.com> (raw)
In-Reply-To: <CAJZ5v0g4q8N5wMgk7pRYpYoCLPQoH==Z+nrM0JLyFXSgF9y0+Q@mail.gmail.com>
On 6/22/22 05:05, Rafael J. Wysocki wrote:
> On Mon, Jun 20, 2022 at 9:08 PM Andrew Lunn <andrew@lunn.ch> wrote:
>>
>> On Mon, Jun 20, 2022 at 05:02:21PM +0200, Marcin Wojtas wrote:
>>> The MDIO bus is responsible for probing and registering its respective
>>> children, such as PHYs or other kind of devices.
>>>
>>> It is required that ACPI scan code should not enumerate such
>>> devices, leaving this task for the generic MDIO bus routines,
>>> which are initiated by the controller driver.
>>
>> I suppose the question is, should you ignore the ACPI way of doing
>> things, or embrace the ACPI way?
>
> What do you mean by "the ACPI way"?
>
>> At least please add a comment why the ACPI way is wrong, despite this
>> being an ACPI binding.
>
> The question really is whether or not it is desirable to create
> platform devices for all of the objects found in the ACPI tables that
> correspond to the devices on the MDIO bus.
If we have devices hanging off a MDIO bus then they are mdio_device (and
possibly a more specialized object with the phy_device which does embedd
a mdio_device object), not platform devices, since MDIO is a bus in itself.
--
Florian
next prev parent reply other threads:[~2022-06-22 16:12 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-20 15:02 [net-next: PATCH 00/12] ACPI support for DSA Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 01/12] net: phy: fixed_phy: switch to fwnode_ API Marcin Wojtas
2022-06-20 17:25 ` Andy Shevchenko
2022-06-20 17:59 ` Andrew Lunn
2022-06-21 9:56 ` Marcin Wojtas
2022-06-21 10:01 ` Russell King (Oracle)
2022-06-20 15:02 ` [net-next: PATCH 02/12] net: mdio: switch fixed-link PHYs API to fwnode_ Marcin Wojtas
2022-06-20 17:32 ` Andy Shevchenko
2022-06-21 9:22 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 03/12] net: dsa: switch to device_/fwnode_ APIs Marcin Wojtas
2022-06-20 17:41 ` Andy Shevchenko
2022-06-21 9:27 ` Marcin Wojtas
2022-06-21 11:02 ` Andy Shevchenko
2022-06-22 16:09 ` Florian Fainelli
2022-06-20 15:02 ` [net-next: PATCH 04/12] net: mvpp2: initialize port fwnode pointer Marcin Wojtas
2022-06-20 17:43 ` Andy Shevchenko
2022-06-20 17:44 ` Andy Shevchenko
2022-06-21 9:28 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 05/12] net: core: switch to fwnode_find_net_device_by_node() Marcin Wojtas
2022-06-20 17:46 ` Andy Shevchenko
2022-06-20 23:15 ` Marcin Wojtas
2022-06-20 22:30 ` kernel test robot
2022-06-20 15:02 ` [net-next: PATCH 06/12] net: mdio: introduce fwnode_mdiobus_register_device() Marcin Wojtas
2022-06-20 17:48 ` Andy Shevchenko
2022-06-21 9:33 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 07/12] net: mdio: allow registering non-PHY devices in ACPI world Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 08/12] ACPI: scan: prevent double enumeration of MDIO bus children Marcin Wojtas
2022-06-20 17:53 ` Andy Shevchenko
2022-06-20 23:04 ` Marcin Wojtas
2022-06-22 12:09 ` Rafael J. Wysocki
2022-06-22 15:05 ` Marcin Wojtas
2022-06-20 19:08 ` Andrew Lunn
2022-06-22 12:05 ` Rafael J. Wysocki
2022-06-22 16:12 ` Florian Fainelli [this message]
2022-06-22 16:21 ` Rafael J. Wysocki
2022-06-23 7:41 ` Andrew Lunn
2022-06-23 23:07 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 09/12] Documentation: ACPI: DSD: introduce DSA description Marcin Wojtas
2022-06-20 18:19 ` Andrew Lunn
2022-06-20 23:21 ` Marcin Wojtas
2022-06-20 19:47 ` Andrew Lunn
2022-06-20 23:25 ` Marcin Wojtas
2022-06-21 11:09 ` Andy Shevchenko
2022-06-21 11:18 ` Andrew Lunn
2022-06-21 11:42 ` Andy Shevchenko
2022-06-22 9:08 ` Marcin Wojtas
2022-06-22 9:24 ` Andrew Lunn
2022-06-22 10:22 ` Marcin Wojtas
2022-06-22 10:37 ` Andrew Lunn
2022-06-22 11:08 ` Andy Shevchenko
2022-06-22 11:04 ` Andy Shevchenko
2022-06-22 11:03 ` Andy Shevchenko
2022-06-22 11:22 ` Andrew Lunn
2022-06-22 14:20 ` Andy Shevchenko
2022-06-22 15:00 ` Marcin Wojtas
2022-06-21 9:45 ` Sudeep Holla
2022-06-21 11:15 ` Andy Shevchenko
2022-06-21 11:24 ` Andrew Lunn
2022-06-21 11:46 ` Andy Shevchenko
2022-06-21 11:57 ` Andrew Lunn
2022-06-21 13:28 ` Sudeep Holla
2022-06-21 15:23 ` Rafael J. Wysocki
2022-06-21 15:37 ` Sudeep Holla
2022-06-21 16:00 ` Rafael J. Wysocki
2022-06-21 18:11 ` Sudeep Holla
2022-06-20 15:02 ` [net-next: PATCH 10/12] net: dsa: add ACPI support Marcin Wojtas
2022-06-20 18:32 ` Andrew Lunn
2022-06-20 23:31 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 11/12] net: dsa: mv88e6xxx: switch to device_/fwnode_ APIs Marcin Wojtas
2022-06-20 18:00 ` Andy Shevchenko
2022-06-21 9:14 ` Marcin Wojtas
2022-06-20 18:04 ` Andy Shevchenko
2022-06-21 9:15 ` Marcin Wojtas
2022-06-20 15:02 ` [net-next: PATCH 12/12] net: dsa: mv88e6xxx: add ACPI support Marcin Wojtas
2022-06-25 2:54 ` kernel test robot
2022-06-20 17:21 ` [net-next: PATCH 00/12] ACPI support for DSA Andy Shevchenko
2022-06-21 10:02 ` Marcin Wojtas
2022-06-20 17:55 ` Andrew Lunn
2022-06-20 18:07 ` Andy Shevchenko
2022-06-20 18:45 ` Andrew Lunn
2022-06-21 10:46 ` Marcin Wojtas
2022-06-22 15:40 ` Marcin Wojtas
2022-06-22 16:14 ` Andy Shevchenko
2022-06-21 10:16 ` Marcin Wojtas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54618c2a-e1f3-bbd0-8fb2-1669366a3b59@gmail.com \
--to=f.fainelli@gmail.com \
--cc=Samer.El-Haj-Mahmoud@arm.com \
--cc=andrew@lunn.ch \
--cc=andriy.shevchenko@linux.intel.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gjb@semihalf.com \
--cc=hkallweit1@gmail.com \
--cc=jaz@semihalf.com \
--cc=kuba@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mw@semihalf.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
--cc=rafael@kernel.org \
--cc=tn@semihalf.com \
--cc=upstream@semihalf.com \
--cc=vivien.didelot@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).