From: Jamal Hadi Salim <jhs@mojatatu.com>
To: Jiri Pirko <jiri@resnulli.us>, Cong Wang <cwang@twopensource.com>
Cc: netdev <netdev@vger.kernel.org>,
David Miller <davem@davemloft.net>,
Pravin B Shelar <pshelar@nicira.com>,
Tom Herbert <therbert@google.com>,
Eric Dumazet <edumazet@google.com>,
willemb@google.com, Daniel Borkmann <dborkman@redhat.com>,
mst@redhat.com, Florian Westphal <fw@strlen.de>,
Paul.Durrant@citrix.com, Thomas Graf <tgraf@suug.ch>
Subject: Re: [patch net-next 2/2] sched: introduce vlan action
Date: Wed, 12 Nov 2014 07:27:24 -0500 [thread overview]
Message-ID: <5463522C.1030104@mojatatu.com> (raw)
In-Reply-To: <20141112074755.GA1882@nanopsycho.orion>
On 11/12/14 02:47, Jiri Pirko wrote:
> Wed, Nov 12, 2014 at 12:18:47AM CET, cwang@twopensource.com wrote:
>> I know vlan tag is not exactly the skb metadata, but still seems
>> fits in skbedit for me.
>
> I was thinking about that as well. It seems much clearer to add a new
> action.
>
Cong,
I think it is better to have all these "tunneling" activities
as a separate action each. It is cleaner from a usability perspective.
[e.g. it is not hard to express nat action with pedit action or take
checksum out of nat since we have a csum action), but makes sense to
have it separate)].
cheers,
jamal
next prev parent reply other threads:[~2014-11-12 12:27 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-11 10:13 [patch net-next 1/2] net: move vlan pop/push functions into common code Jiri Pirko
2014-11-11 10:13 ` [patch net-next 2/2] sched: introduce vlan action Jiri Pirko
2014-11-11 12:34 ` Jamal Hadi Salim
2014-11-11 22:33 ` Cong Wang
2014-11-12 12:34 ` Jiri Pirko
2014-11-12 13:03 ` Jamal Hadi Salim
2014-11-12 13:06 ` Jamal Hadi Salim
2014-11-11 23:18 ` Cong Wang
2014-11-12 7:47 ` Jiri Pirko
2014-11-12 12:27 ` Jamal Hadi Salim [this message]
2014-11-13 17:06 ` Cong Wang
2014-11-11 13:06 ` [patch net-next 1/2] net: move vlan pop/push functions into common code Eric Dumazet
2014-11-11 15:00 ` Jiri Pirko
2014-11-11 17:24 ` Pravin Shelar
2014-11-12 11:59 ` Jiri Pirko
2014-11-12 19:11 ` David Miller
2014-11-12 19:20 ` Pravin Shelar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5463522C.1030104@mojatatu.com \
--to=jhs@mojatatu.com \
--cc=Paul.Durrant@citrix.com \
--cc=cwang@twopensource.com \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=edumazet@google.com \
--cc=fw@strlen.de \
--cc=jiri@resnulli.us \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=pshelar@nicira.com \
--cc=tgraf@suug.ch \
--cc=therbert@google.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).