From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Lendacky Subject: Re: [patch -next] amd-xgbe: fix ->rss_hash_type Date: Wed, 12 Nov 2014 09:45:40 -0600 Message-ID: <546380A4.1030105@amd.com> References: <20141112083135.GA12795@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit Cc: , To: Dan Carpenter Return-path: Received: from [157.56.110.145] ([157.56.110.145]:41944 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-FAIL-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1752686AbaKLPqK (ORCPT ); Wed, 12 Nov 2014 10:46:10 -0500 In-Reply-To: <20141112083135.GA12795@mwanda> Sender: netdev-owner@vger.kernel.org List-ID: On 11/12/2014 02:31 AM, Dan Carpenter wrote: > There was a missing break statement so we set everything to > PKT_HASH_TYPE_L3 even when we intended to use PKT_HASH_TYPE_L4. > > Fixes: 5b9dfe299e55 ('amd-xgbe: Provide support for receive side scaling') > Signed-off-by: Dan Carpenter Acked-by: Tom Lendacky > --- > This driver has a lot of Sparse endian warnings. > http://lwn.net/Articles/205624/ I'll send a patch to address the endian warnings. Thanks, Tom > > diff --git a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c > index 7daa2cd..55ba1dc 100644 > --- a/drivers/net/ethernet/amd/xgbe/xgbe-dev.c > +++ b/drivers/net/ethernet/amd/xgbe/xgbe-dev.c > @@ -1601,6 +1601,7 @@ static int xgbe_dev_read(struct xgbe_channel *channel) > case RX_DESC3_L34T_IPV6_UDP: > packet->rss_hash_type = PKT_HASH_TYPE_L4; > > + break; > default: > packet->rss_hash_type = PKT_HASH_TYPE_L3; > } >