netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Yoshihiro Kaneko <ykaneko0929@gmail.com>, netdev@vger.kernel.org
Cc: "David S. Miller" <davem@davemloft.net>,
	Simon Horman <horms@verge.net.au>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-sh@vger.kernel.org, Grant Likely <grant.likely@linaro.org>
Subject: Re: [PATCH] sh_eth: r8a779x: Enable automatically fetch receive descriptor
Date: Fri, 14 Nov 2014 00:57:39 +0300	[thread overview]
Message-ID: <54652953.9030300@cogentembedded.com> (raw)
In-Reply-To: <1415861819-27812-1-git-send-email-ykaneko0929@gmail.com>

Hello.

On 11/13/2014 09:56 AM, Yoshihiro Kaneko wrote:

> From: Kouei Abe <kouei.abe.cp@renesas.com>

> HDMAC automatically fetches the receive descriptor and receives frames.
> Continuous reception of multiple frames is possible.

> Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---

> This patch is based on net-next tree.

    This patch is not needed any more because of an earlier patch by Ben Dooks 
that set RMCR.RNC for all Ether devices.

>   drivers/net/ethernet/renesas/sh_eth.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index dbe8606..badb734 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -494,6 +494,7 @@ static struct sh_eth_cpu_data r8a779x_data = {
>   	.eesr_err_check	= EESR_TWB | EESR_TABT | EESR_RABT | EESR_RFE |
>   			  EESR_RDE | EESR_RFRMER | EESR_TFE | EESR_TDE |
>   			  EESR_ECI,
> +	.rmcr_value	= RMCR_RNC,

    Looks like you didn't even bother to compile.

WBR, Sergei


      parent reply	other threads:[~2014-11-13 21:57 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-13  6:56 [PATCH] sh_eth: r8a779x: Enable automatically fetch receive descriptor Yoshihiro Kaneko
2014-11-13 20:03 ` David Miller
2014-11-13 21:59   ` Sergei Shtylyov
2014-11-13 21:57 ` Sergei Shtylyov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54652953.9030300@cogentembedded.com \
    --to=sergei.shtylyov@cogentembedded.com \
    --cc=davem@davemloft.net \
    --cc=grant.likely@linaro.org \
    --cc=horms@verge.net.au \
    --cc=linux-sh@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=netdev@vger.kernel.org \
    --cc=ykaneko0929@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).