[PATCH] sh_eth: r8a779x: Enable automatically fetch receive descriptor

[PATCH] sh_eth: r8a779x: Enable automatically fetch receive descriptor

[Yoshihiro Kaneko]

From: Kouei Abe <kouei.abe.cp@renesas.com>

HDMAC automatically fetches the receive descriptor and receives frames.
Continuous reception of multiple frames is possible.

Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
---

This patch is based on net-next tree.

 drivers/net/ethernet/renesas/sh_eth.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index dbe8606..badb734 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -494,6 +494,7 @@ static struct sh_eth_cpu_data r8a779x_data = {
 	.eesr_err_check	= EESR_TWB | EESR_TABT | EESR_RABT | EESR_RFE |
 			  EESR_RDE | EESR_RFRMER | EESR_TFE | EESR_TDE |
 			  EESR_ECI,
+	.rmcr_value	= RMCR_RNC,
 
 	.apr		= 1,
 	.mpr		= 1,
-- 
1.9.1

Re: [PATCH] sh_eth: r8a779x: Enable automatically fetch receive descriptor

[David Miller]

From: Yoshihiro Kaneko <ykaneko0929@gmail.com>
Date: Thu, 13 Nov 2014 15:56:59 +0900

> From: Kouei Abe <kouei.abe.cp@renesas.com>
> 
> HDMAC automatically fetches the receive descriptor and receives frames.
> Continuous reception of multiple frames is possible.
> 
> Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---
> 
> This patch is based on net-next tree.

This doesn't even compile, or, it depends upon another patch which you have
not mentioned.

Because sh_eth_cpu_data does not have an rmcr_value field.

Re: [PATCH] sh_eth: r8a779x: Enable automatically fetch receive descriptor

[Sergei Shtylyov]

Hello.

On 11/13/2014 11:03 PM, David Miller wrote:

>> From: Kouei Abe <kouei.abe.cp@renesas.com>

>> HDMAC automatically fetches the receive descriptor and receives frames.
>> Continuous reception of multiple frames is possible.

>> Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
>> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
>> ---
>>
>> This patch is based on net-next tree.
>
> This doesn't even compile, or, it depends upon another patch which you have
> not mentioned.

    This patch is just very outdated -- this issue has been fixed for all SoCs 
before.

> Because sh_eth_cpu_data does not have an rmcr_value field.

     Right, it was removed by the above mentioned patch (based on your 
feedback BTW ;-).

WBR, Sergei

Re: [PATCH] sh_eth: r8a779x: Enable automatically fetch receive descriptor

[Sergei Shtylyov]

Hello.

On 11/13/2014 09:56 AM, Yoshihiro Kaneko wrote:

> From: Kouei Abe <kouei.abe.cp@renesas.com>

> HDMAC automatically fetches the receive descriptor and receives frames.
> Continuous reception of multiple frames is possible.

> Signed-off-by: Kouei Abe <kouei.abe.cp@renesas.com>
> Signed-off-by: Yoshihiro Kaneko <ykaneko0929@gmail.com>
> ---

> This patch is based on net-next tree.

    This patch is not needed any more because of an earlier patch by Ben Dooks 
that set RMCR.RNC for all Ether devices.

>   drivers/net/ethernet/renesas/sh_eth.c | 1 +
>   1 file changed, 1 insertion(+)
>
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index dbe8606..badb734 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -494,6 +494,7 @@ static struct sh_eth_cpu_data r8a779x_data = {
>   	.eesr_err_check	= EESR_TWB | EESR_TABT | EESR_RABT | EESR_RFE |
>   			  EESR_RDE | EESR_RFRMER | EESR_TFE | EESR_TDE |
>   			  EESR_ECI,
> +	.rmcr_value	= RMCR_RNC,

    Looks like you didn't even bother to compile.

WBR, Sergei