From: Roger Quadros <rogerq@ti.com>
To: <wg@grandegger.com>, <mkl@pengutronix.de>
Cc: <wsa@the-dreams.de>, <tony@atomide.com>, <tglx@linutronix.de>,
<mugunthanvnm@ti.com>, <george.cherian@ti.com>, <balbi@ti.com>,
<nsekhar@ti.com>, <nm@ti.com>,
<sergei.shtylyov@cogentembedded.com>,
<linux-omap@vger.kernel.org>, <linux-can@vger.kernel.org>,
<netdev@vger.kernel.org>, Roger Quadros <rogerq@ti.com>
Subject: [PATCH v7 6/8] net: can: c_can: Disable pins when CAN interface is down
Date: Fri, 14 Nov 2014 17:40:13 +0200 [thread overview]
Message-ID: <5466225D.2070202@ti.com> (raw)
In-Reply-To: <5464CCFF.5010004@ti.com>
DRA7 CAN IP suffers from a problem which causes it to be prevented
from fully turning OFF (i.e. stuck in transition) if the module was
disabled while there was traffic on the CAN_RX line.
To work around this issue we select the SLEEP pin state by default
on probe and use the DEFAULT pin state on CAN up and back to the
SLEEP pin state on CAN down.
Signed-off-by: Roger Quadros <rogerq@ti.com>
---
drivers/net/can/c_can/c_can.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/net/can/c_can/c_can.c b/drivers/net/can/c_can/c_can.c
index 8e78bb4..f94a9fa 100644
--- a/drivers/net/can/c_can/c_can.c
+++ b/drivers/net/can/c_can/c_can.c
@@ -35,6 +35,7 @@
#include <linux/list.h>
#include <linux/io.h>
#include <linux/pm_runtime.h>
+#include <linux/pinctrl/consumer.h>
#include <linux/can.h>
#include <linux/can/dev.h>
@@ -603,6 +604,8 @@ static int c_can_start(struct net_device *dev)
priv->can.state = CAN_STATE_ERROR_ACTIVE;
+ /* activate pins */
+ pinctrl_pm_select_default_state(dev->dev.parent);
return 0;
}
@@ -611,6 +614,9 @@ static void c_can_stop(struct net_device *dev)
struct c_can_priv *priv = netdev_priv(dev);
c_can_irq_control(priv, false);
+
+ /* deactivate pins */
+ pinctrl_pm_select_sleep_state(dev->dev.parent);
priv->can.state = CAN_STATE_STOPPED;
}
@@ -1244,6 +1250,13 @@ int register_c_can_dev(struct net_device *dev)
struct c_can_priv *priv = netdev_priv(dev);
int err;
+ /* Deactivate pins to prevent DRA7 DCAN IP from being
+ * stuck in transition when module is disabled.
+ * Pins are activated in c_can_start() and deactivated
+ * in c_can_stop()
+ */
+ pinctrl_pm_select_sleep_state(dev->dev.parent);
+
c_can_pm_runtime_enable(priv);
dev->flags |= IFF_ECHO; /* we support local echo */
--
1.8.3.2
next prev parent reply other threads:[~2014-11-14 15:40 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-07 14:49 [PATCH v4 0/8] net: can: Use syscon regmap for TI specific RAMINIT register Roger Quadros
2014-11-07 14:49 ` [PATCH v4 1/8] net: can: c_can: Add timeout to c_can_hw_raminit_ti() Roger Quadros
2014-11-07 14:49 ` [PATCH v4 2/8] net: can: c_can: Introduce c_can_driver_data structure Roger Quadros
2014-11-13 10:57 ` Marc Kleine-Budde
2014-11-07 14:49 ` [PATCH v4 3/8] net: can: c_can: Add RAMINIT register information to driver data Roger Quadros
2014-11-13 10:59 ` Marc Kleine-Budde
2014-11-14 17:55 ` Marc Kleine-Budde
2014-11-17 11:17 ` Roger Quadros
2014-11-17 11:22 ` Marc Kleine-Budde
2014-11-17 11:29 ` Roger Quadros
2014-11-07 14:49 ` [PATCH v4 4/8] net: can: c_can: Add syscon/regmap RAMINIT mechanism Roger Quadros
2014-11-13 11:09 ` Marc Kleine-Budde
2014-11-13 12:09 ` Roger Quadros
2014-11-13 12:58 ` Marc Kleine-Budde
2014-11-13 12:44 ` Marc Kleine-Budde
2014-11-13 13:07 ` Roger Quadros
2014-11-14 15:37 ` [PATCH v5 " Roger Quadros
2014-11-14 16:32 ` Marc Kleine-Budde
2014-11-14 16:42 ` Roger Quadros
2014-11-07 14:49 ` [PATCH v4 5/8] net: can: c_can: Add support for START pulse in RAMINIT sequence Roger Quadros
2014-11-07 14:49 ` [PATCH v4 6/8] net: can: c_can: Disable pins when CAN interface is down Roger Quadros
2014-11-07 14:54 ` Marc Kleine-Budde
2014-11-10 9:00 ` Roger Quadros
2014-11-12 14:16 ` [PATCH v5 " Roger Quadros
2014-11-13 12:56 ` Marc Kleine-Budde
2014-11-13 13:04 ` Roger Quadros
2014-11-13 15:23 ` Roger Quadros
2014-11-13 16:03 ` Marc Kleine-Budde
2014-11-14 13:43 ` Roger Quadros
2014-11-27 13:28 ` Linus Walleij
2014-11-14 15:40 ` Roger Quadros [this message]
2014-11-14 15:49 ` [PATCH v7 " Marc Kleine-Budde
2014-11-14 16:04 ` Roger Quadros
2014-11-27 13:26 ` Linus Walleij
2014-11-27 21:19 ` Marc Kleine-Budde
2014-11-28 9:22 ` Roger Quadros
2014-11-07 14:49 ` [PATCH v4 7/8] net: can: c_can: Add support for TI DRA7 DCAN Roger Quadros
2014-11-14 15:56 ` Marc Kleine-Budde
2014-11-07 14:49 ` [PATCH v4 8/8] net: can: c_can: Add support for TI am3352 DCAN Roger Quadros
2014-11-13 16:06 ` Wolfram Sang
2014-11-14 9:25 ` Marc Kleine-Budde
2014-11-14 11:26 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5466225D.2070202@ti.com \
--to=rogerq@ti.com \
--cc=balbi@ti.com \
--cc=george.cherian@ti.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=mkl@pengutronix.de \
--cc=mugunthanvnm@ti.com \
--cc=netdev@vger.kernel.org \
--cc=nm@ti.com \
--cc=nsekhar@ti.com \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=tglx@linutronix.de \
--cc=tony@atomide.com \
--cc=wg@grandegger.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).