From: Rick Jones <rick.jones2@hp.com>
To: Eric Dumazet <eric.dumazet@gmail.com>, Rick Jones <raj@tardy.usa.hp.com>
Cc: netdev@vger.kernel.org, davem@davemloft.net
Subject: Re: [PATCH net-next] icmp: Remove some spurious dropped packet profile hits from the ICMP path
Date: Fri, 14 Nov 2014 08:16:57 -0800 [thread overview]
Message-ID: <54662AF9.4050002@hp.com> (raw)
In-Reply-To: <1415931471.17262.27.camel@edumazet-glaptop2.roam.corp.google.com>
>
> This looks quite complicated to me.
>
> Why are you adding kfree_skb() everywhere instead of :
>
> bool to_consume = icmp_pointers[icmph->type].handler(skb);
> if (ro_consume)
> consume_skb(skb);
> else
> kfree_skb(skb);
I thought the point of the drop profiling was to show where the drops
were happening. Leaving the kfree_skb() up in icmp_rcv() does not
improve showing where the drops happened. That is why I've pushed it
down into the routines called by icmp_rcv().
rick
next prev parent reply other threads:[~2014-11-14 16:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-13 22:54 [PATCH net-next] icmp: Remove some spurious dropped packet profile hits from the ICMP path Rick Jones
2014-11-14 1:32 ` David Miller
2014-11-14 2:17 ` Eric Dumazet
2014-11-14 16:16 ` Rick Jones [this message]
2014-11-14 16:58 ` Eric Dumazet
2014-11-14 18:29 ` Rick Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54662AF9.4050002@hp.com \
--to=rick.jones2@hp.com \
--cc=davem@davemloft.net \
--cc=eric.dumazet@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=raj@tardy.usa.hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).