From: Mietek N <namiltd@yahoo.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"edumazet@google.com" <edumazet@google.com>,
"alsi@bang-olufsen.dk" <alsi@bang-olufsen.dk>,
"olteanv@gmail.com" <olteanv@gmail.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"davem@davemloft.net" <davem@davemloft.net>
Subject: Re: [PATCH] net: dsa: realtek: rtl8365mb: fix return value in rtl8365mb_phy_ocp_write
Date: Sun, 16 Nov 2025 20:09:40 +0000 (UTC) [thread overview]
Message-ID: <546988473.8766254.1763323780441@mail.yahoo.com> (raw)
In-Reply-To: <1c0ee3d4-2b24-48ea-b34f-b5653abe11d4@lunn.ch>
[PATCH v4] net: dsa: realtek: rtl8365mb: fix return value in rtl8365mb_phy_ocp_write
Function rtl8365mb_phy_ocp_write() always returns 0, even when an error
occurs during register access. This patch fixes the return value to
propagate the actual error code from regmap operations.
Fixes: 2796728460b822d549841e0341752b263dc265c4 ("net: dsa: realtek: rtl8365mb: serialize indirect PHY register access")
Signed-off-by: Mieczyslaw Nalewaj <namiltd@yahoo.com>
---
drivers/net/dsa/realtek/rtl8365mb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/dsa/realtek/rtl8365mb.c b/drivers/net/dsa/realtek/rtl8365mb.c
index 964a56e..d06b384 100644
--- a/drivers/net/dsa/realtek/rtl8365mb.c
+++ b/drivers/net/dsa/realtek/rtl8365mb.c
@@ -769,7 +769,7 @@ static int rtl8365mb_phy_ocp_write(struct realtek_priv *priv, int phy,
out:
rtl83xx_unlock(priv);
- return 0;
+ return ret;
}
static int rtl8365mb_phy_read(struct realtek_priv *priv, int phy, int regnum)
--
2.43.0
next prev parent reply other threads:[~2025-11-16 20:10 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <2114795695.8721689.1763312184906.ref@mail.yahoo.com>
2025-11-16 16:56 ` [PATCH] net: dsa: realtek: rtl8365mb: fix return value in rtl8365mb_phy_ocp_write Mietek N
2025-11-16 17:18 ` Mietek N
2025-11-16 19:32 ` Andrew Lunn
2025-11-16 20:09 ` Mietek N [this message]
2026-01-03 19:12 ` [PATCH v2] net: dsa: realtek: rtl8365mb: remove ifOutDiscards from rx_packets Mieczyslaw Nalewaj
2026-01-03 19:17 ` [PATCH v3] " Mieczyslaw Nalewaj
2026-01-04 15:31 ` Jakub Kicinski
2026-01-04 15:54 ` [PATCH v4] " Mieczyslaw Nalewaj
2026-01-04 17:01 ` Jakub Kicinski
2026-01-04 17:39 ` [PATCH v5] " Mieczyslaw Nalewaj
2026-01-04 17:52 ` Jakub Kicinski
2026-01-05 8:35 ` Mieczyslaw Nalewaj
2026-01-05 14:23 ` Andrew Lunn
2026-01-04 11:25 ` [PATCH] net: dsa: realtek: rtl8365mb: fix return value in rtl8365mb_phy_ocp_write Mieczyslaw Nalewaj
2026-01-04 21:11 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546988473.8766254.1763323780441@mail.yahoo.com \
--to=namiltd@yahoo.com \
--cc=alsi@bang-olufsen.dk \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).