Re: Question about Patch Submissions

[rapier <rapier@psc.edu>]

Cong,

Thanks for the response.

It's a pretty extensive patch set and we're trying to make sure it makes 
sense in context. It touches quite a few files and they're mostly 
interdependent. That's why we're having problems trying to figure out 
how to break this down for presentation. We can make sure each section 
of the patch applies cleanly but the entirety of the patch set would 
have to be applied for it to compile.

Chris

On 11/18/14, 3:21 PM, Cong Wang wrote:
> On Tue, Nov 18, 2014 at 11:13 AM, rapier <rapier@psc.edu> wrote:
>> I've read the documentation I've been able to find on the patch submission
>> process. I was hoping to clarify one thing though. When submitting a patch
>> that spans multiple files and functions is it better to break the submission
>> down by function or by file?
>>
>
> It depends on what you change, if your patch is trivial, say just cleaning up
> whitespaces, or a big single patch doesn't harm review, it is okay not
> to split it.
> Otherwise, probably you need to split it logically, each of which needs to at
> least compile.
>