From: Daniel Borkmann <dborkman@redhat.com>
To: Cong Wang <cwang@twopensource.com>
Cc: Hamad Kadmany <hkadmany@codeaurora.org>,
Jiri Pirko <jiri@resnulli.us>, netdev <netdev@vger.kernel.org>,
tgraf@suug.ch
Subject: Re: [PATCH] net: team: expose sysfs attributes for each team option
Date: Wed, 19 Nov 2014 20:17:01 +0100 [thread overview]
Message-ID: <546CECAD.1040402@redhat.com> (raw)
In-Reply-To: <CAHA+R7OOnSfSP1uHrg=osH=+=sb-0Zj-=yYx8HXmpO95v+Dhyg@mail.gmail.com>
On 11/19/2014 07:45 PM, Cong Wang wrote:
> On Wed, Nov 19, 2014 at 4:28 AM, Hamad Kadmany <hkadmany@codeaurora.org> wrote:
>> On Mon, November 17, 2014 1:02 pm, Jiri Pirko wrote:
>>>
>>> Nak.
>>>
>>> I don't like this patch. The plan for team was keep things simple and to
>>> have single userspace api using netlink, as that is the correct way to
>>> deal with things. Sysfs for this use-case is not. Please, use netlink api.
+1
>> Using team driver requires using libnl3. In Android based platforms, libnl3
>> is not supported, and libnl3 license poses constraints in Android's user-space.
Constraints?! libnl3 is LGPL ...
> Check if libmnl fits your license:
> http://www.netfilter.org/projects/libmnl/
... and this one, too.
next prev parent reply other threads:[~2014-11-19 19:17 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-17 10:11 [PATCH] net: team: expose sysfs attributes for each team option Hamad Kadmany
2014-11-17 13:02 ` Jiri Pirko
2014-11-19 12:28 ` Hamad Kadmany
2014-11-19 12:40 ` Jiri Pirko
2014-11-19 18:26 ` David Miller
2014-11-25 15:37 ` Jiri Pirko
2014-11-19 12:41 ` Jiri Pirko
2014-11-19 18:24 ` David Miller
2014-11-19 18:45 ` Cong Wang
2014-11-19 19:17 ` Daniel Borkmann [this message]
2014-11-20 16:05 ` Thomas Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=546CECAD.1040402@redhat.com \
--to=dborkman@redhat.com \
--cc=cwang@twopensource.com \
--cc=hkadmany@codeaurora.org \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=tgraf@suug.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).