netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* FIX ME in e1000_82575.c
@ 2014-11-23  4:42 nick
  2014-11-24 16:32 ` [linux-nics] " Fujinaka, Todd
  0 siblings, 1 reply; 3+ messages in thread
From: nick @ 2014-11-23  4:42 UTC (permalink / raw)
  To: jeffrey.t.kirsher@intel.com >> Jeff Kirsher
  Cc: linux.nics, e1000-devel, bruce.w.allan, jesse.brandeburg, netdev,
	linux-kernel

Greetings Again Jeff,
I am wondering about sending in a patch to FIX ME in the file, e1000_82575 due to incorrect values in the function,
igdb_acquire_swfw_sync_82575. If you or one of the other maintainers at Intel can send me the correct values or a hardware reference for me to find the values, I would be glad to send it a patch fixing these outstanding issues.
Regards Nick 

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired

^ permalink raw reply	[flat|nested] 3+ messages in thread

* RE: [linux-nics] FIX ME in e1000_82575.c
  2014-11-23  4:42 FIX ME in e1000_82575.c nick
@ 2014-11-24 16:32 ` Fujinaka, Todd
  2014-11-24 19:14   ` nick
  0 siblings, 1 reply; 3+ messages in thread
From: Fujinaka, Todd @ 2014-11-24 16:32 UTC (permalink / raw)
  To: nick, Kirsher, Jeffrey T
  Cc: Linux NICS, e1000-devel@lists.sourceforge.net, Vick, Matthew,
	netdev@vger.kernel.org, Wyborny, Carolyn,
	linux-kernel@vger.kernel.or

I'm not sure there's much need to actually change the value. It's been the same since 2007 when the log message says, "Removed FIXME comment."

I think someone forgot to remove the second FIXME comment. I'll send a patch.

Todd Fujinaka
Software Application Engineer
Networking Division (ND)
Intel Corporation
todd.fujinaka@intel.com
(503) 712-4565

-----Original Message-----
From: linux-nics-bounces@isotope.jf.intel.com [mailto:linux-nics-bounces@isotope.jf.intel.com] On Behalf Of nick
Sent: Saturday, November 22, 2014 8:43 PM
To: Kirsher, Jeffrey T
Cc: Linux NICS; e1000-devel@lists.sourceforge.net; Vick, Matthew; netdev@vger.kernel.org; Wyborny, Carolyn; linux-kernel@vger.kernel.or
Subject: [linux-nics] FIX ME in e1000_82575.c

Greetings Again Jeff,
I am wondering about sending in a patch to FIX ME in the file, e1000_82575 due to incorrect values in the function, igdb_acquire_swfw_sync_82575. If you or one of the other maintainers at Intel can send me the correct values or a hardware reference for me to find the values, I would be glad to send it a patch fixing these outstanding issues.
Regards Nick
_______________________________________________
Linux-nics mailing list
Linux-nics@intel.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [linux-nics] FIX ME in e1000_82575.c
  2014-11-24 16:32 ` [linux-nics] " Fujinaka, Todd
@ 2014-11-24 19:14   ` nick
  0 siblings, 0 replies; 3+ messages in thread
From: nick @ 2014-11-24 19:14 UTC (permalink / raw)
  To: Fujinaka, Todd, Kirsher, Jeffrey T
  Cc: e1000-devel@lists.sourceforge.net, netdev@vger.kernel.org,
	Linux NICS, linux-kernel@vger.kernel.or

Sounds good enough, just a question why is my email bouncing against linux-nics mailing list?
Cheers Nick

On 14-11-24 11:32 AM, Fujinaka, Todd wrote:
> I'm not sure there's much need to actually change the value. It's been the same since 2007 when the log message says, "Removed FIXME comment."
> 
> I think someone forgot to remove the second FIXME comment. I'll send a patch.
> 
> Todd Fujinaka
> Software Application Engineer
> Networking Division (ND)
> Intel Corporation
> todd.fujinaka@intel.com
> (503) 712-4565
> 
> -----Original Message-----
> From: linux-nics-bounces@isotope.jf.intel.com [mailto:linux-nics-bounces@isotope.jf.intel.com] On Behalf Of nick
> Sent: Saturday, November 22, 2014 8:43 PM
> To: Kirsher, Jeffrey T
> Cc: Linux NICS; e1000-devel@lists.sourceforge.net; Vick, Matthew; netdev@vger.kernel.org; Wyborny, Carolyn; linux-kernel@vger.kernel.or
> Subject: [linux-nics] FIX ME in e1000_82575.c
> 
> Greetings Again Jeff,
> I am wondering about sending in a patch to FIX ME in the file, e1000_82575 due to incorrect values in the function, igdb_acquire_swfw_sync_82575. If you or one of the other maintainers at Intel can send me the correct values or a hardware reference for me to find the values, I would be glad to send it a patch fixing these outstanding issues.
> Regards Nick
> _______________________________________________
> Linux-nics mailing list
> Linux-nics@intel.com
> 

------------------------------------------------------------------------------
Download BIRT iHub F-Type - The Free Enterprise-Grade BIRT Server
from Actuate! Instantly Supercharge Your Business Reports and Dashboards
with Interactivity, Sharing, Native Excel Exports, App Integration & more
Get technology previously reserved for billion-dollar corporations, FREE
http://pubads.g.doubleclick.net/gampad/clk?id=157005751&iu=/4140/ostg.clktrk
_______________________________________________
E1000-devel mailing list
E1000-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/e1000-devel
To learn more about Intel® Ethernet, visit http://communities.intel.com/community/wired

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2014-11-24 19:14 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-11-23  4:42 FIX ME in e1000_82575.c nick
2014-11-24 16:32 ` [linux-nics] " Fujinaka, Todd
2014-11-24 19:14   ` nick

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).