From: Toshiaki Makita <makita.toshiaki@lab.ntt.co.jp>
To: Mahesh Bandewar <maheshb@google.com>
Cc: netdev <netdev@vger.kernel.org>,
Eric Dumazet <edumazet@google.com>,
Maciej Zenczykowski <maze@google.com>,
Laurent Chavey <chavey@google.com>,
Tim Hockin <thockin@google.com>,
David Miller <davem@davemloft.net>,
Brandon Philips <brandon.philips@coreos.com>,
Pavel Emelianov <xemul@parallels.com>
Subject: Re: [PATCH net-next v4] ipvlan: Initial check-in of the IPVLAN driver.
Date: Thu, 27 Nov 2014 10:59:58 +0900 [thread overview]
Message-ID: <5476859E.609@lab.ntt.co.jp> (raw)
In-Reply-To: <CAF2d9jgZkgk4kOyS7K959vEq_55DuEnkVdxzKPdmPiTxFfPvsg@mail.gmail.com>
On 2014/11/27 2:05, Mahesh Bandewar wrote:
> On Tue, Nov 25, 2014 at 10:41 PM, Toshiaki Makita
> <makita.toshiaki@lab.ntt.co.jp> wrote:
>> Hi Mahesh,
>>
>> I found that deleting the last ipvlan device triggers WARN_ON() in
>> rtmsg_ifinfo().
>> ipvlan_nl_fillinfo() seems to return -EINVAL in that case.
>>
>>> +static int ipvlan_nl_fillinfo(struct sk_buff *skb,
>>> + const struct net_device *dev)
>>> +{
>>> + struct ipvl_dev *ipvlan = netdev_priv(dev);
>>> + struct ipvl_port *port = ipvlan_port_get_rtnl(ipvlan->phy_dev);
>>> + int ret = -EINVAL;
>>> +
>>> + if (!port)
>>> + goto err;
>>> +
>>> + ret = -EMSGSIZE;
>>> + if (nla_put_u16(skb, IFLA_IPVLAN_MODE, port->mode))
>>> + goto err;
>>> +
>>> + return 0;
>>> +
>>> +err:
>>> + return ret;
>>> +}
>>
>> rollback_registered_many() calls rtmsg_ifinfo() after calling ndo_uninit().
>> ndo_uninit() (ipvlan_uninit() -> ipvlan_port_destroy() ->
>> netdev_rx_handler_unregister()) sets rx_handler_data into NULL.
>> So, we cannot dereference "port" in ipvlan_nl_fillinfo().
>>
> Calling fillinfo() after calling uninit() seems pointless on any
> device.
bonding needs calling rtmsg_ifinfo() after calling ndo_uninit().
56bfa7ee7c88 ("unregister_netdevice : move RTM_DELLINK to until after
ndo_uninit")
> But how are you hitting this case? Can you share the command
> sequence with me?
# ip link add link eth0 name ipvl0 type ipvlan
# ip link del ipvl0
Thanks,
Toshiaki Makita
>
> Thanks,
> --mahesh..
>
>> Maybe "mode" should belong to struct ipvl_dev?
>>
>> Thanks,
>> Toshiaki Makita
next prev parent reply other threads:[~2014-11-27 2:00 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-24 7:07 [PATCH net-next v4] ipvlan: Initial check-in of the IPVLAN driver Mahesh Bandewar
2014-11-24 20:29 ` David Miller
2014-11-26 6:41 ` Toshiaki Makita
2014-11-26 17:05 ` Mahesh Bandewar
2014-11-27 1:59 ` Toshiaki Makita [this message]
2014-11-27 6:55 ` Mahesh Bandewar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5476859E.609@lab.ntt.co.jp \
--to=makita.toshiaki@lab.ntt.co.jp \
--cc=brandon.philips@coreos.com \
--cc=chavey@google.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=maheshb@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=thockin@google.com \
--cc=xemul@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).