From: Jason Wang <jasowang@redhat.com>
To: David Miller <davem@davemloft.net>
Cc: kaber@trash.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org, mst@redhat.com,
vyasevic@redhat.com
Subject: Re: [PATCH net-next] macvlan: delay the header check for dodgy packets into lower device
Date: Thu, 27 Nov 2014 13:14:28 +0800 [thread overview]
Message-ID: <5476B334.1050706@redhat.com> (raw)
In-Reply-To: <20141126.153736.1815789848350571029.davem@davemloft.net>
On 11/27/2014 04:37 AM, David Miller wrote:
> From: Jason Wang <jasowang@redhat.com>
> Date: Wed, 26 Nov 2014 17:21:14 +0800
>
>> We do header check twice for a dodgy packet. One is done before
>> macvlan_start_xmit(), another is done before lower device's
>> ndo_start_xmit(). The first one seems redundant so this patch tries to
>> delay header check until a packet reaches its lower device (or macvtap)
>> through always enabling NETIF_F_GSO_ROBUST for macvlan device.
>>
>> Cc: Patrick McHardy <kaber@trash.net>
>> Signed-off-by: Jason Wang <jasowang@redhat.com>
>
> Hmmm, it's the idea that if we have a dodgy packet, we want to
> notice that as early as possible in the packet processing path?
>
Not late even with this patch. The check will be done immediately after
macvlan passing a packet to lower device which should be sufficient.
For good packets, this patch saves one time of header checking. For bad
packets, this patch just lets the dropping happens during the validation
before ndo_start_xmit() of lower device.
next prev parent reply other threads:[~2014-11-27 5:14 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-26 9:21 [PATCH net-next] macvlan: delay the header check for dodgy packets into lower device Jason Wang
2014-11-26 20:37 ` David Miller
2014-11-27 5:14 ` Jason Wang [this message]
2014-11-30 4:45 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5476B334.1050706@redhat.com \
--to=jasowang@redhat.com \
--cc=davem@davemloft.net \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mst@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=vyasevic@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).