From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jamal Hadi Salim Subject: Re: [patch net-next v4 09/21] bridge: call netdev_sw_port_stp_update when bridge port STP status changes Date: Thu, 27 Nov 2014 08:14:20 -0500 Message-ID: <547723AC.1070907@mojatatu.com> References: <1417084826-9875-1-git-send-email-jiri@resnulli.us> <1417084826-9875-10-git-send-email-jiri@resnulli.us> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, nhorman@tuxdriver.com, andy@greyhouse.net, tgraf@suug.ch, dborkman@redhat.com, ogerlitz@mellanox.com, jesse@nicira.com, pshelar@nicira.com, azhou@nicira.com, ben@decadent.org.uk, stephen@networkplumber.org, jeffrey.t.kirsher@intel.com, vyasevic@redhat.com, xiyou.wangcong@gmail.com, john.r.fastabend@intel.com, edumazet@google.com, sfeldma@gmail.com, f.fainelli@gmail.com, roopa@cumulusnetworks.com, linville@tuxdriver.com, jasowang@redhat.com, ebiederm@xmission.com, nicolas.dichtel@6wind.com, ryazanov.s.a@gmail.com, buytenh@wantstofly.org, aviadr@mellanox.com, nbd@openwrt.org, alexei.starovoitov@gmail.com, Neil.Jerram@metaswitch.com, ronye@mellanox.com, simon.horman@netronome.com, alexander.h.duyck@redhat.com, john.ronciak@intel.com, mleitner@redhat.com, shrijeet@gmail.com, gospo@cumulusnetworks.com, bcrl@kvack.org, hemal@broadcom.com To: Jiri Pirko , netdev@vger.kernel.org Return-path: Received: from mail-ie0-f178.google.com ([209.85.223.178]:52467 "EHLO mail-ie0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750784AbaK0NOY (ORCPT ); Thu, 27 Nov 2014 08:14:24 -0500 Received: by mail-ie0-f178.google.com with SMTP id tp5so4515851ieb.37 for ; Thu, 27 Nov 2014 05:14:24 -0800 (PST) In-Reply-To: <1417084826-9875-10-git-send-email-jiri@resnulli.us> Sender: netdev-owner@vger.kernel.org List-ID: On 11/27/14 05:40, Jiri Pirko wrote: > From: Scott Feldman > > To notify switch driver of change in STP state of bridge port, add new > .ndo op and provide switchdev wrapper func to call ndo op. Use it in bridge > code then. > As it stands right now we are going to pollute the ndo ops and grow it fatter like the skb (its probably as fat). If i am not mistaken ethtool has some scheme it uses to pass opaque objects to different functions. Having a generic set/get_netdev_offload_attr() would be the right thing to do. An {id, *value} or {id, len, *value} or a void * would do. So not objecting - but not ACKing either. cheers, jamal