From: FengYu LeiDian <fengyuleidian0615@gmail.com>
To: Li RongQing <roy.qing.li@gmail.com>
Cc: netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH iproute2] ip xfrm: support 64bit kernel and 32bit userspace
Date: Fri, 28 Nov 2014 16:07:40 +0800 [thread overview]
Message-ID: <54782D4C.60407@gmail.com> (raw)
In-Reply-To: <CAJFZqHyHaD7+6fqjmsVh_JeDrto5SmN2D6rZkjWa3axfM0+AiA@mail.gmail.com>
于 2014年11月28日 15:35, Li RongQing 写道:
> On Fri, Nov 28, 2014 at 3:08 PM, FengYu LeiDian
> <fengyuleidian0615@gmail.com> wrote:
>> >于 2014年11月28日 14:58,roy.qing.li@gmail.com 写道:
>>> >>From: Li RongQing<roy.qing.li@gmail.com>
>>> >>
>>> >>The size of struct xfrm_userpolicy_info is 168 bytes for 64bit kernel, and
>>> >>164 bytes for 32bit userspace because of the different alignment. and lead
>>> >>to "ip xfrm" be unable to work.
>>> >>
>>> >>add a pad in struct xfrm_userpolicy_info, and enable it by set
>>> >>KERNEL_64_USERSPACE_32 to y
>> >
>> >
>> >It's not easy to fix it like this.
>> >
>> >Refer:
>> >http://marc.info/?l=linux-netdev&m=139280143513650&w=2
>> >http://thread.gmane.org/gmane.linux.network/157118/focus=157122
>> >
> is it be practical to find all structures which has the issue for
> 64bit kernel and 32 bit
> userspace, and conditionally add a pad for them
Apparently struct xfrm_userpolicy_info is not the only one,
you could try to set SA as well, it breaks also...
Fix those where it hurts, hehe :) Otherwise, the "compat layer"
fix style is good choice.
next prev parent reply other threads:[~2014-11-28 8:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 6:58 [PATCH iproute2] ip xfrm: support 64bit kernel and 32bit userspace roy.qing.li
2014-11-28 7:08 ` FengYu LeiDian
2014-11-28 7:35 ` Li RongQing
2014-11-28 8:07 ` FengYu LeiDian [this message]
2014-11-28 10:47 ` David Laight
2014-11-30 1:33 ` Ben Hutchings
2014-11-30 17:42 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54782D4C.60407@gmail.com \
--to=fengyuleidian0615@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=roy.qing.li@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).