From: nick <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: "Michael Büsch" <m@bues.ch>,
"Rafał Miłecki" <zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Network Development
<netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
"linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org"
<linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Stefano Brivio
<stefano.brivio-hl5o88x/ua9eoWH0uzbU5w@public.gmane.org>,
b43-dev
<b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>
Subject: Re: [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c
Date: Fri, 28 Nov 2014 22:32:30 -0500 [thread overview]
Message-ID: <54793E4E.7050602@gmail.com> (raw)
In-Reply-To: <20141129002148.1beb21d9@wiggum>
Michael,
I don't have hardware for this driver on me, so I didn't test it. However this seems to
be correct from my reading of the code around this function and other locking related
to this driver.
Cheers Nick
On 2014-11-28 06:21 PM, Michael Büsch wrote:
> On Fri, 28 Nov 2014 23:40:46 +0100
> Rafał Miłecki <zajec5@gmail.com> wrote:
>
>>> @@ -5094,8 +5094,9 @@ static int b43_op_beacon_set_tim(struct ieee80211_hw *hw,
>>> {
>>> struct b43_wl *wl = hw_to_b43_wl(hw);
>>>
>>> - /* FIXME: add locking */
>>> + mutex_lock(&wl->mutex);
>>> b43_update_templates(wl);
>>> + mutex_unlock(&wl->mutex);
>>>
>>> return 0;
>>> }
>>
>> Does anyone remember why this simple solution wasn't implemented
>> earlier? Michael?
>
> I think the callback used to be (is?) in atomic context.
>
>> Nicholas: did you test it anyhow?
>
_______________________________________________
b43-dev mailing list
b43-dev@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/b43-dev
next prev parent reply other threads:[~2014-11-29 3:32 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-28 22:16 [PATCH] drivers:net:wireless: Add mutex locking for function, b43_op_beacon_set_time in main.c Nicholas Krause
2014-11-28 22:40 ` Rafał Miłecki
2014-11-28 23:21 ` Michael Büsch
2014-11-29 3:32 ` nick [this message]
2014-11-29 8:54 ` Rafał Miłecki
2014-11-29 8:56 ` Michael Büsch
2014-11-29 9:04 ` Rafał Miłecki
[not found] ` <CACna6ryjZ-LY06wAMzoL77Wca3McUUT+VYsO4EPO87NqjBnaNw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-11-29 18:09 ` nick
[not found] ` <547A0BC5.2080005-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-11-29 18:54 ` Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54793E4E.7050602@gmail.com \
--to=xerofoify-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
--cc=b43-dev-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-wireless-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=m@bues.ch \
--cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=stefano.brivio-hl5o88x/ua9eoWH0uzbU5w@public.gmane.org \
--cc=zajec5-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).