From mboxrd@z Thu Jan 1 00:00:00 1970 From: Larry Finger Subject: Re: Non Explained TODOs in halbtcoutsrc.c Date: Sat, 29 Nov 2014 22:31:13 -0600 Message-ID: <547A9D91.9080406@lwfinger.net> References: <547A581A.7040609@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: linux-wireless@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org To: nick Return-path: In-Reply-To: <547A581A.7040609@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 11/29/2014 05:34 PM, nick wrote: > Greetings Larry, > After reading the code around the TODOS, I can't understand you reasoning for them in this file as they seem to > unneeded as the logic for the switch statement with them seems to be fine. If there are reasons for them in this > file, it would be nice to hear from you on why they are needed as TODO as a comment is rather unclear for anybody > reading this file. > Nick I did not write that code. I merely make it available through the git repo, and modify it so that it will build on all kernel versions. I do not understand the TODOs any more than you do. Larry