From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mirko Lindner Subject: Re: [PATCH] skge: Unmask interrupts in case of spurious interrupts Date: Mon, 1 Dec 2014 10:53:31 +0100 Message-ID: <547C3A9B.4060407@marvell.com> References: <1417348291-1302-1-git-send-email-LinoSanfilippo@gmx.de> Mime-Version: 1.0 Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit Cc: , , To: Lino Sanfilippo Return-path: In-Reply-To: <1417348291-1302-1-git-send-email-LinoSanfilippo@gmx.de> Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 30/11/14 12:51, Lino Sanfilippo wrote: > In case of a spurious interrupt dont forget to reenable the interrupts that > have been masked by reading the interrupt source register. > > Signed-off-by: Lino Sanfilippo > --- > drivers/net/ethernet/marvell/skge.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/marvell/skge.c b/drivers/net/ethernet/marvell/skge.c > index 264eab7..7173836 100644 > --- a/drivers/net/ethernet/marvell/skge.c > +++ b/drivers/net/ethernet/marvell/skge.c > @@ -3433,10 +3433,9 @@ static irqreturn_t skge_intr(int irq, void *dev_id) > > if (status & IS_HW_ERR) > skge_error_irq(hw); > - > +out: > skge_write32(hw, B0_IMSK, hw->intr_mask); > skge_read32(hw, B0_IMSK); > -out: > spin_unlock(&hw->hw_lock); > > return IRQ_RETVAL(handled); > Looks OK. Acked-by: Mirko Lindner