From: Andrey Volkov <andrey.volkov@nexvision.fr>
To: netdev@vger.kernel.org
Cc: Florian Fainelli <f.fainelli@gmail.com>
Subject: [PATCH 1/1] net: dsa: replacing the hard-coded sized array "dsa_switch" by dynamic one
Date: Tue, 02 Dec 2014 15:50:46 +0100 [thread overview]
Message-ID: <547DD1C6.2090304@nexvision.fr> (raw)
Hello,
In time of developing one of our devices (with huge, more then 6, number of onboard switches),
I've bumped with this ancient, I hope, restriction in the 'struct dsa_switch_tree' definition.
So this simple patch remove this restriction and make dsa_switch_tree more scalable for
the "usual" 1-2 switches configuration too.
P.S. I've plans to fix hardcoded number of ports too, but it is not so easy as with number of switches.
So if someone have any objections/suggestions I'll happy to discuss them.
Signed-off-by: Andrey Volkov <andrey.volkov@nexvision.fr>
---
include/net/dsa.h | 3 +--
net/dsa/dsa.c | 7 +++----
2 files changed, 4 insertions(+), 6 deletions(-)
diff --git a/include/net/dsa.h b/include/net/dsa.h
index ed3c34b..733db2e 100644
--- a/include/net/dsa.h
+++ b/include/net/dsa.h
@@ -28,7 +28,6 @@ enum dsa_tag_protocol {
DSA_TAG_PROTO_BRCM,
};
-#define DSA_MAX_SWITCHES 4
#define DSA_MAX_PORTS 12
struct dsa_chip_data {
@@ -117,7 +116,7 @@ struct dsa_switch_tree {
/*
* Data for the individual switch chips.
*/
- struct dsa_switch *ds[DSA_MAX_SWITCHES];
+ struct dsa_switch *ds[];
};
struct dsa_switch {
diff --git a/net/dsa/dsa.c b/net/dsa/dsa.c
index 322c778..c081a19 100644
--- a/net/dsa/dsa.c
+++ b/net/dsa/dsa.c
@@ -604,8 +604,6 @@ static int dsa_of_probe(struct platform_device *pdev)
pdev->dev.platform_data = pd;
pd->netdev = ðernet_dev->dev;
pd->nr_chips = of_get_child_count(np);
- if (pd->nr_chips > DSA_MAX_SWITCHES)
- pd->nr_chips = DSA_MAX_SWITCHES;
pd->chip = kcalloc(pd->nr_chips, sizeof(struct dsa_chip_data),
GFP_KERNEL);
@@ -717,7 +715,7 @@ static int dsa_probe(struct platform_device *pdev)
pd = pdev->dev.platform_data;
}
- if (pd == NULL || pd->netdev == NULL)
+ if (pd == NULL || pd->netdev == NULL || pd->nr_chips == 0)
return -EINVAL;
dev = dev_to_net_device(pd->netdev);
@@ -732,7 +730,8 @@ static int dsa_probe(struct platform_device *pdev)
goto out;
}
- dst = kzalloc(sizeof(*dst), GFP_KERNEL);
+ dst = kzalloc(sizeof(*dst) +
+ sizeof(struct dsa_switch *) * pd->nr_chips, GFP_KERNEL);
if (dst == NULL) {
dev_put(dev);
ret = -ENOMEM;
next reply other threads:[~2014-12-02 15:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-02 14:50 Andrey Volkov [this message]
2014-12-02 20:40 ` [PATCH 1/1] net: dsa: replacing the hard-coded sized array "dsa_switch" by dynamic one Florian Fainelli
2014-12-04 15:54 ` [PATCH v2 " Andrey Volkov
2014-12-09 19:45 ` David Miller
2014-12-04 17:29 ` [PATCH " Andrey Volkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=547DD1C6.2090304@nexvision.fr \
--to=andrey.volkov@nexvision.fr \
--cc=f.fainelli@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).